✗ CI.checkpatch: warning for Improve error path handling for firmware loading

Patchwork patchwork at emeril.freedesktop.org
Thu Feb 1 23:22:04 UTC 2024


== Series Details ==

Series: Improve error path handling for firmware loading
URL   : https://patchwork.freedesktop.org/series/129443/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
35591fb8b4d5305b37ce31483f85ac0956eaa536
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 1bb25f6953ff760bd0e6bcc2937aca5e070d8902
Author: Lucas De Marchi <lucas.demarchi at intel.com>
Date:   Thu Feb 1 14:47:24 2024 -0800

    drm/xe: Avoid crypt message when there's no GuC definition
    
    If there's no GuC firmware entry in the table and the user didn't pass
    an override path, the error message is very crypt: xe will simply try to
    continue and then fail when submitting the default context:
    
            xe 0000:00:02.0: [drm:xe_pci_probe [xe]] XE_LUNARLAKE  64b0:0001 dgfx:0 gfx:Xe2_LPG (20.04) media:Xe2_LPM (20.00) display:no dma_m_s:46 tc:1 gscfi:0
            ...
            xe: probe of 0000:00:02.0 failed with error -22
    
    Add an explicit error message and bail out:
    
            xe 0000:00:02.0: [drm:xe_pci_probe [xe]] XE_LUNARLAKE  64b0:0001 dgfx:0 gfx:Xe2_LPG (20.04) media:Xe2_LPM (20.00) display:no dma_m_s:46 tc:1 gscfi:0
            xe 0000:00:02.0: [drm] *ERROR* No GuC firmware defined for platform
            xe 0000:00:02.0: [drm] *ERROR* GuC init failed with -2
            ...
            xe: probe of 0000:00:02.0 failed with error -2
    
    Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
+ /mt/dim checkpatch 18a9fefd9e05291cbe792d358bbdc04dc6d21adb drm-intel
619d06a23 drm/xe: Always allow to override firmware
1bb25f695 drm/xe: Avoid crypt message when there's no GuC definition
-:10: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#10: 
	xe 0000:00:02.0: [drm:xe_pci_probe [xe]] XE_LUNARLAKE  64b0:0001 dgfx:0 gfx:Xe2_LPG (20.04) media:Xe2_LPM (20.00) display:no dma_m_s:46 tc:1 gscfi:0

total: 0 errors, 1 warnings, 0 checks, 14 lines checked




More information about the Intel-xe mailing list