✗ CI.checkpatch: warning for series starting with [v3,1/4] drm/xe: Add uapi for dumpable bos (rev2)

[Patchwork]

== Series Details ==

Series: series starting with [v3,1/4] drm/xe: Add uapi for dumpable bos (rev2)
URL   : https://patchwork.freedesktop.org/series/129496/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
35591fb8b4d5305b37ce31483f85ac0956eaa536
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 680e657dd658120ae93e2f02cd949d44d1bfab22
Author: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Date:   Fri Feb 2 23:45:14 2024 +0100

    drm/xe: Implement VM snapshot support for BO's and userptr
    
    Since we cannot immediately capture the BO's and userptr, perform it in
    2 stages. The immediate stage takes a reference to each BO and userptr,
    while a delayed worker captures the contents and then frees the
    reference.
    
    This is required because in signaling context, no locks can be taken, no
    memory can be allocated, and no waits on userspace can be performed.
    
    With the delayed worker, all of this can be performed very easily,
    without having to resort to hacks.
    
    Changes since v1:
    - Fix crash on NULL captured vm.
    - Use ascii85_encode to capture BO contents and save some space.
    - Add length to coredump output for each captured area.
    Changes since v2:
    - Dump each mapping on their own line, to simplify tooling.
    - Fix null pointer deref in xe_vm_snapshot_free.
    
    Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
+ /mt/dim checkpatch 40994da55437acf620a48af39b0d8545e1595c42 drm-intel
5d4eaf749 drm/xe: Add uapi for dumpable bos
d63ecc1d6 drm/xe: Annotate each dumpable vma as such
73dc06fb4 drm/xe: Add vm snapshot mutex for easily taking a vm snapshot during devcoredump
680e657dd drm/xe: Implement VM snapshot support for BO's and userptr
-:158: WARNING:TYPO_SPELLING: 'deffered' may be misspelled - perhaps 'deferred'?
#158: FILE: drivers/gpu/drm/xe/xe_devcoredump_types.h:32:
+	/** @work: Workqueue for deffered capture outside of signaling context */
 	                         ^^^^^^^^

-:193: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u64' over 'uint64_t'
#193: FILE: drivers/gpu/drm/xe/xe_vm.c:3288:
+		uint64_t ofs, bo_ofs;

-:238: WARNING:LINE_SPACING: Missing a blank line after declarations
#238: FILE: drivers/gpu/drm/xe/xe_vm.c:3333:
+			struct xe_userptr *userptr = &to_userptr_vma(vma)->userptr;
+			if (mmget_not_zero(userptr->notifier.mm))

-:283: WARNING:LINE_SPACING: Missing a blank line after declarations
#283: FILE: drivers/gpu/drm/xe/xe_vm.c:3378:
+			void __user *userptr = (void __user *)(size_t)snap->snap[i].bo_ofs;
+			kthread_use_mm(snap->snap[i].mm);

-:318: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#318: FILE: drivers/gpu/drm/xe/xe_vm.c:3413:
+			uint32_t *val = snap->snap[i].data + j;

total: 0 errors, 3 warnings, 2 checks, 305 lines checked