[RFC 24/34] drm/xe: Remove useless mem_access protection for query ioctls

[Matthew Auld]

On 26/01/2024 20:30, Rodrigo Vivi wrote:
> Every IOCTL is already protected on its outer bounds by
> xe_pm_runtime_{get,put} calls, so we can now remove
> these.
> 
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

Should this be squashed?

Reviewed-by: Matthew Auld <matthew.auld at intel.com>

> ---
>   drivers/gpu/drm/xe/xe_query.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_query.c b/drivers/gpu/drm/xe/xe_query.c
> index 9b35673b286c..86222c80a874 100644
> --- a/drivers/gpu/drm/xe/xe_query.c
> +++ b/drivers/gpu/drm/xe/xe_query.c
> @@ -147,7 +147,6 @@ query_engine_cycles(struct xe_device *xe,
>   	if (!hwe)
>   		return -EINVAL;
>   
> -	xe_device_mem_access_get(xe);
>   	xe_force_wake_get(gt_to_fw(gt), XE_FORCEWAKE_ALL);
>   
>   	__read_timestamps(gt,
> @@ -159,7 +158,6 @@ query_engine_cycles(struct xe_device *xe,
>   			  cpu_clock);
>   
>   	xe_force_wake_put(gt_to_fw(gt), XE_FORCEWAKE_ALL);
> -	xe_device_mem_access_put(xe);
>   	resp.width = 36;
>   
>   	/* Only write to the output fields of user query */
> @@ -437,9 +435,7 @@ static int query_hwconfig(struct xe_device *xe,
>   	if (!hwconfig)
>   		return -ENOMEM;
>   
> -	xe_device_mem_access_get(xe);
>   	xe_guc_hwconfig_copy(&gt->uc.guc, hwconfig);
> -	xe_device_mem_access_put(xe);
>   
>   	if (copy_to_user(query_ptr, hwconfig, size)) {
>   		kfree(hwconfig);