✗ CI.checkpatch: warning for drm/xe: support VM sharing between apps

Patchwork patchwork at emeril.freedesktop.org
Tue Feb 6 15:06:59 UTC 2024


== Series Details ==

Series: drm/xe: support VM sharing between apps
URL   : https://patchwork.freedesktop.org/series/129582/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
35591fb8b4d5305b37ce31483f85ac0956eaa536
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit c2ffa07ca70c35a26bc68404435b06d81c5a54ad
Author: Bharat Jauhari <bjauhari at habana.ai>
Date:   Tue Feb 6 16:18:20 2024 +0200

    drm/xe: support to export VM as fd
    
    In some situations, drivers and applications need to share a VM.
    Currently a VM is exposed to the user as an integer. This integer
    has no meaning outside the context/application created it.
    This commit adds support to export VM ID as an FD which can be shared.
    User is allowed to export a VM only once. Consecutive calls to export
    the same VM will return with an error.
    
    Signed-off-by: Bharat Jauhari <bjauhari at habana.ai>
+ /mt/dim checkpatch 8a42fafc783505db4f1d6a70005a5f103069c9d9 drm-intel
69b4dff66 drm/xe: add ref count to xe_file
-:50: CHECK:LINE_SPACING: Please don't use multiple blank lines
#50: FILE: drivers/gpu/drm/xe/xe_device.c:90:
 
+

total: 0 errors, 0 warnings, 1 checks, 105 lines checked
c2ffa07ca drm/xe: support to export VM as fd
-:89: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*vm_file)...) over kzalloc(sizeof(struct xe_vm_file)...)
#89: FILE: drivers/gpu/drm/xe/xe_vm.c:3303:
+	vm_file = kzalloc(sizeof(struct xe_vm_file), GFP_KERNEL);

-:179: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#179: FILE: drivers/gpu/drm/xe/xe_vm.h:184:
+int xe_vm_export_ioctl(struct drm_device *dev, void *data,
+			struct drm_file *file);

-:191: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'vm' - possible side-effects?
#191: FILE: drivers/gpu/drm/xe/xe_vm_types.h:122:
+#define xe_vm_scale_in_use(vm) ((vm)->scale_info.exported_vm || (vm)->scale_info.registered_vm)

-:260: WARNING:LONG_LINE: line length of 118 exceeds 100 columns
#260: FILE: include/uapi/drm/xe_drm.h:118:
+#define DRM_IOCTL_XE_VM_EXPORT			DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_VM_EXPORT, struct drm_xe_vm_export)

total: 0 errors, 1 warnings, 3 checks, 248 lines checked




More information about the Intel-xe mailing list