[PATCH 0/6] drm/i915/display: DMC wakelock implementation

Luca Coelho luciano.coelho at intel.com
Wed Feb 7 10:30:01 UTC 2024


Hi,

This is the third version of my series, now not as an RFC anymore, but
as a proper patchset.

This is what changed compared to RFC v2:

  * Renamed intel_wakelock.[ch] to intel_dmc_wl.[ch]
  * Renamed all functions to match the new file name, intel_dmc_wl_*()
  * Removed the excessive logging
  * Added comment about other CTL registers
  * Changed DMC_WAKELOCK_CFG_ENABLE to DMC_WAKELOCK_CTL_REQ for the
    control registers
  * Add disable function
  * Add module parameter
  * Moved the init to DMC load and added disable

This is one item I promised to look into, but didn't derive into any
code changes:

  * No need to bail out on refcount == 0 in the work handler


Please review.

Cheers,
Luca.


Luca Coelho (6):
  drm/i915/display: add support for DMC wakelocks
  drm/i915/display: use wakelock in the remaining read operations
  drm/i915/display: use wakelock in register waiting functions
  drm/i915/display: use wakelock in the last write function
  drm/i915/display: add module parameter to enable DMC wakelock
  drm/i915/display: call DMC wakelock enable when DMC is loaded

 drivers/gpu/drm/i915/Makefile                 |   1 +
 drivers/gpu/drm/i915/display/intel_de.h       | 119 ++++++++++-
 drivers/gpu/drm/i915/display/intel_display.c  |   1 +
 .../gpu/drm/i915/display/intel_display_core.h |   4 +
 .../drm/i915/display/intel_display_driver.c   |   1 +
 .../drm/i915/display/intel_display_params.c   |   5 +
 .../drm/i915/display/intel_display_params.h   |   1 +
 drivers/gpu/drm/i915/display/intel_dmc.c      |   8 +
 drivers/gpu/drm/i915/display/intel_dmc_regs.h |  32 +++
 drivers/gpu/drm/i915/display/intel_dmc_wl.c   | 197 ++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_dmc_wl.h   |  35 ++++
 drivers/gpu/drm/xe/Makefile                   |   1 +
 12 files changed, 395 insertions(+), 10 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_dmc_wl.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_dmc_wl.h

-- 
2.39.2



More information about the Intel-xe mailing list