✗ CI.checkpatch: warning for drm/i915/display: DMC wakelock implementation (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915/display: DMC wakelock implementation (rev2)
URL   : https://patchwork.freedesktop.org/series/128628/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
35591fb8b4d5305b37ce31483f85ac0956eaa536
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 70308230dc377ed3a71871dfaa32ab252fe86495
Author: Luca Coelho <luciano.coelho at intel.com>
Date:   Wed Feb 7 12:30:07 2024 +0200

    drm/i915/display: call DMC wakelock enable when DMC is loaded
    
    Although the documentation says that this should be done in the first
    modeset, it makes more sense to enable and disable it when DMC is
    enabled and disabled, including during suspend and resume operations.
    
    Add the calls to enable and disable DMC wakelock accordingly.
    
    Signed-off-by: Luca Coelho <luciano.coelho at intel.com>
+ /mt/dim checkpatch e33f766ecfa1aee40eec83b3a146eb84a5e23222 drm-intel
08764c426 drm/i915/display: add support for DMC wakelocks
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:118: CHECK:LINE_SPACING: Please don't use multiple blank lines
#118: FILE: drivers/gpu/drm/i915/display/intel_display_core.h:540:
+
+

-:176: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#176: 
new file mode 100644

-:181: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/gpu/drm/i915/display/intel_dmc_wl.c', please use '//' instead
#181: FILE: drivers/gpu/drm/i915/display/intel_dmc_wl.c:1:
+/* SPDX-License-Identifier: MIT */

-:181: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#181: FILE: drivers/gpu/drm/i915/display/intel_dmc_wl.c:1:
+/* SPDX-License-Identifier: MIT */

-:281: WARNING:RETURN_VOID: void function return statements are not generally useful
#281: FILE: drivers/gpu/drm/i915/display/intel_dmc_wl.c:101:
+	return;
+}

-:310: WARNING:RETURN_VOID: void function return statements are not generally useful
#310: FILE: drivers/gpu/drm/i915/display/intel_dmc_wl.c:130:
+	return;
+}

-:339: CHECK:LINE_SPACING: Please don't use multiple blank lines
#339: FILE: drivers/gpu/drm/i915/display/intel_dmc_wl.c:159:
+
+

-:389: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#389: FILE: drivers/gpu/drm/i915/display/intel_dmc_wl.h:18:
+	spinlock_t lock;

total: 0 errors, 5 warnings, 3 checks, 350 lines checked
d94f42c45 drm/i915/display: use wakelock in the remaining read operations
d1c391716 drm/i915/display: use wakelock in register waiting functions
-:6: WARNING:TYPO_SPELLING: 'functonality' may be misspelled - perhaps 'functionality'?
#6: 
Add the wakelock functonality to the functions that help wait for
                 ^^^^^^^^^^^^

total: 0 errors, 1 warnings, 0 checks, 66 lines checked
e4dc12948 drm/i915/display: use wakelock in the last write function
24da8dba7 drm/i915/display: add module parameter to enable DMC wakelock
-:24: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#24: FILE: drivers/gpu/drm/i915/display/intel_display_params.c:120:
+intel_display_param_named_unsafe(enable_dmc_wl, bool, 0400,
+	"Enable DMC wakelock "

total: 0 errors, 0 warnings, 1 checks, 58 lines checked
70308230d drm/i915/display: call DMC wakelock enable when DMC is loaded