✗ CI.checkpatch: warning for series starting with [v4,1/4] drm/xe: Add uapi for dumpable bos

Patchwork patchwork at emeril.freedesktop.org
Tue Feb 13 15:12:51 UTC 2024


== Series Details ==

Series: series starting with [v4,1/4] drm/xe: Add uapi for dumpable bos
URL   : https://patchwork.freedesktop.org/series/129839/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
35591fb8b4d5305b37ce31483f85ac0956eaa536
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 1587ab392efe91953e0029a01d020d53eb48134c
Author: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Date:   Tue Feb 13 15:52:39 2024 +0100

    drm/xe: Implement VM snapshot support for BO's and userptr
    
    Since we cannot immediately capture the BO's and userptr, perform it in
    2 stages. The immediate stage takes a reference to each BO and userptr,
    while a delayed worker captures the contents and then frees the
    reference.
    
    This is required because in signaling context, no locks can be taken, no
    memory can be allocated, and no waits on userspace can be performed.
    
    With the delayed worker, all of this can be performed very easily,
    without having to resort to hacks.
    
    Changes since v1:
    - Fix crash on NULL captured vm.
    - Use ascii85_encode to capture BO contents and save some space.
    - Add length to coredump output for each captured area.
    Changes since v2:
    - Dump each mapping on their own line, to simplify tooling.
    - Fix null pointer deref in xe_vm_snapshot_free.
    Changes since v3:
    - Don't add uninitialized value to snap->ofs. (Souza)
    - Use kernel types for u32 and u64.
    - Move snap_mutex destruction to final vm destruction. (Souza)
    
    Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
+ /mt/dim checkpatch d0229df104dedf0539086dddfab2fc7d60aa103f drm-intel
b0aca7903 drm/xe: Add uapi for dumpable bos
3e8bde71c drm/xe: Annotate each dumpable vma as such
e80efed20 drm/xe: Add vm snapshot mutex for easily taking a vm snapshot during devcoredump
1587ab392 drm/xe: Implement VM snapshot support for BO's and userptr
-:308: WARNING:LINE_SPACING: Missing a blank line after declarations
#308: FILE: drivers/gpu/drm/xe/xe_vm.c:3364:
+			void __user *userptr = (void __user *)(size_t)snap->snap[i].bo_ofs;
+			kthread_use_mm(snap->snap[i].mm);

total: 0 errors, 1 warnings, 0 checks, 324 lines checked




More information about the Intel-xe mailing list