[PATCH 1/3] drm/xe: Allow vram bo allocations aligned to 64K
Rodrigo Vivi
rodrigo.vivi at intel.com
Tue Feb 13 22:28:02 UTC 2024
On Tue, Feb 13, 2024 at 10:24:16PM +0100, Michal Wajdeczko wrote:
> While today we are getting vram allocations aligned to 64K as the
> XE_VRAM_FLAGS_NEED64K flag could be set, we shouldn't only rely on
> that flag and we should also allow caller to specify required 64K
> alignment explicitly. Define new XE_BO_NEEDS_64K flag for that.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Matt Roper <matthew.d.roper at intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> ---
> drivers/gpu/drm/xe/xe_bo.c | 3 ++-
> drivers/gpu/drm/xe/xe_bo.h | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
> index d6a193060cc0..9da8bf506ab0 100644
> --- a/drivers/gpu/drm/xe/xe_bo.c
> +++ b/drivers/gpu/drm/xe/xe_bo.c
> @@ -1256,7 +1256,8 @@ struct xe_bo *___xe_bo_create_locked(struct xe_device *xe, struct xe_bo *bo,
>
> if (flags & (XE_BO_CREATE_VRAM_MASK | XE_BO_CREATE_STOLEN_BIT) &&
> !(flags & XE_BO_CREATE_IGNORE_MIN_PAGE_SIZE_BIT) &&
> - xe->info.vram_flags & XE_VRAM_FLAGS_NEED64K) {
> + ((xe->info.vram_flags & XE_VRAM_FLAGS_NEED64K) ||
> + (flags & XE_BO_NEEDS_64K))) {
> aligned_size = ALIGN(size, SZ_64K);
> if (type != ttm_bo_type_device)
> size = ALIGN(size, SZ_64K);
> diff --git a/drivers/gpu/drm/xe/xe_bo.h b/drivers/gpu/drm/xe/xe_bo.h
> index db4b2db6b073..657399b90429 100644
> --- a/drivers/gpu/drm/xe/xe_bo.h
> +++ b/drivers/gpu/drm/xe/xe_bo.h
> @@ -45,6 +45,7 @@
> #define XE_BO_PAGETABLE BIT(12)
> #define XE_BO_NEEDS_CPU_ACCESS BIT(13)
> #define XE_BO_NEEDS_UC BIT(14)
> +#define XE_BO_NEEDS_64K BIT(15)
> /* this one is trigger internally only */
> #define XE_BO_INTERNAL_TEST BIT(30)
> #define XE_BO_INTERNAL_64K BIT(31)
> --
> 2.43.0
>
More information about the Intel-xe
mailing list