✗ CI.checkpatch: warning for drm/xe: get rid of MAX_BINDS

Patchwork patchwork at emeril.freedesktop.org
Thu Feb 15 00:57:56 UTC 2024


== Series Details ==

Series: drm/xe: get rid of MAX_BINDS
URL   : https://patchwork.freedesktop.org/series/129923/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
35591fb8b4d5305b37ce31483f85ac0956eaa536
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 3a65739cb7aace33c8f13da7f2f6ea18ff9492c5
Author: Paulo Zanoni <paulo.r.zanoni at intel.com>
Date:   Wed Feb 14 16:53:53 2024 -0800

    drm/xe: get rid of MAX_BINDS
    
    Mesa has been issuing a single bind operation per ioctl since xe.ko
    changed to GPUVA due xe.ko bug #746. If I change Mesa to try again to
    issue every single bind operation it can in the same ioctl, it hits
    the MAX_BINDS assertion when running Vulkan conformance tests.
    
    Test dEQP-VK.sparse_resources.transfer_queue.3d.rgba32i.1024_128_8
    issues 960 bind operations in a single ioctl, it's the most I could
    find in the conformance suite.
    
    I don't see a reason to keep the MAX_BINDS restriction: it doesn't
    seem to be preventing any specific issue. If the number is too big for
    the memory allocations, then those will fail. Nothing related to
    num_binds seems to be using the stack. Let's just get rid of it.
    
    Testcase: dEQP-VK.sparse_resources.transfer_queue.3d.rgba32i.1024_128_8
    References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/746
    Cc: Matthew Brost <matthew.brost at intel.com>
    Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
+ /mt/dim checkpatch e6a76a4d223eb7b8bcec5d0ae6b1da474823b24a drm-intel
3a65739cb drm/xe: get rid of MAX_BINDS
-:21: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'References:', use 'Link:' or 'Closes:' instead
#21: 
References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/746

total: 0 errors, 1 warnings, 0 checks, 17 lines checked




More information about the Intel-xe mailing list