[PATCH] drm/xe: avoid using 'grouped targets' in Makefile

Dafna Hirschfeld dhirschfeld at habana.ai
Mon Feb 19 13:58:45 UTC 2024


The feature 'grouped target' ('&:') in makefiles is only added in 'make'
version 4.3. This cause problems in older version of 'make'.
(Specifically $(@D) is wrongly interpreted - it creates 'generated' dir
in the source path instead of the build path).
Avoid this feature.

Signed-off-by: Dafna Hirschfeld <dhirschfeld at habana.ai>
---
 drivers/gpu/drm/xe/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index c531210695db..d2c79d3ada67 100644
--- a/drivers/gpu/drm/xe/Makefile
+++ b/drivers/gpu/drm/xe/Makefile
@@ -42,7 +42,7 @@ generated_oob := $(obj)/generated/xe_wa_oob.c $(obj)/generated/xe_wa_oob.h
 quiet_cmd_wa_oob = GEN     $(notdir $(generated_oob))
       cmd_wa_oob = mkdir -p $(@D); $^ $(generated_oob)
 
-$(generated_oob) &: $(obj)/xe_gen_wa_oob $(srctree)/$(src)/xe_wa_oob.rules
+$(generated_oob): $(obj)/xe_gen_wa_oob $(srctree)/$(src)/xe_wa_oob.rules
 	$(call cmd,wa_oob)
 
 uses_generated_oob := \
-- 
2.34.1



More information about the Intel-xe mailing list