[PATCH] drm/xe: Skip TLB invalidation time out log if ct is disabled

Shuicheng Lin shuicheng.lin at intel.com
Tue Feb 20 02:13:56 UTC 2024


Suspend may cause the TLB invalidation time out as below log.
Skip the log print if ct is disabled to make log clean.
"
[  228.812266] xe_gt_tlb_invalidation_wait enter
[  228.812311] xe_gt_suspend enter
[  228.812782] xe 0000:03:00.0: [drm] GT0: suspended
[  228.812786] xe_gt_suspend enter
[  228.813508] xe 0000:03:00.0: [drm] GT1: suspended
…
[  229.067007] xe 0000:03:00.0: [drm] *ERROR* TILE0 [GTT] GT0: TLB invalidation time'd out, seqno=321, recv=319
[  229.067099] xe 0000:03:00.0: [drm] *ERROR* GT0: CT disabled
"

Signed-off-by: Shuicheng Lin <shuicheng.lin at intel.com>
---
 drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
index 7b3a54748b49..8aac12efea84 100644
--- a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
+++ b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
@@ -330,11 +330,18 @@ int xe_gt_tlb_invalidation_wait(struct xe_gt *gt, int seqno)
 	if (!ret) {
 		struct drm_printer p = xe_gt_err_printer(gt);
 
-		xe_tile_report_driver_error(gt_to_tile(gt), XE_TILE_DRV_ERR_GTT,
-					    "GT%u: TLB invalidation time'd out, seqno=%d, recv=%d",
-					    gt->info.id, seqno, gt->tlb_invalidation.seqno_recv);
-		xe_guc_ct_print(&guc->ct, &p, true);
-		return -ETIME;
+		/*
+		 * guc ct may be disabled during the waiting period and lead to the timeout.
+		 * Such as power suspend just after this tlb invalidation wait.
+		 * Skip the error log print if ct is disabled.
+		 */
+		if (xe_guc_ct_enabled(&guc->ct)) {
+			xe_tile_report_driver_error(gt_to_tile(gt), XE_TILE_DRV_ERR_GTT,
+						    "GT%u: TLB invalidation time'd out, seqno=%d, recv=%d",
+						    gt->info.id, seqno, gt->tlb_invalidation.seqno_recv);
+			xe_guc_ct_print(&guc->ct, &p, true);
+			return -ETIME;
+		}
 	}
 
 	return 0;
-- 
2.25.1



More information about the Intel-xe mailing list