[PATCH] drm/xe: avoid using 'grouped targets' in Makefile

Gustavo Sousa gustavo.sousa at intel.com
Tue Feb 20 12:08:42 UTC 2024


Quoting Lucas De Marchi (2024-02-20 02:44:57-03:00)
>On Mon, Feb 19, 2024 at 03:58:45PM +0200, Dafna Hirschfeld wrote:
>>The feature 'grouped target' ('&:') in makefiles is only added in 'make'
>>version 4.3. This cause problems in older version of 'make'.
>>(Specifically $(@D) is wrongly interpreted - it creates 'generated' dir
>>in the source path instead of the build path).
>>Avoid this feature.
>
>but it was used for a reason since a single invocation is supposed to
>generate both the .c and .h from a single invocation. AFAIR when
>implementing this, not using grouped target would be a mix and match on
>having a succesfull build. Does removing it really work with incremental
>and parallel build?

FWIW, the root Makefile does what it calls a "multi-target pattern rule"
trick to get the same behavior.

--
Gustavo

>
>Lucas De Marchi


More information about the Intel-xe mailing list