✗ CI.checkpatch: warning for drm/i915/tv: Fix TV mode

[Patchwork]

== Series Details ==

Series: drm/i915/tv: Fix TV mode
URL   : https://patchwork.freedesktop.org/series/130121/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
35591fb8b4d5305b37ce31483f85ac0956eaa536
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 34ddcffdb887f71016849bcade52be2ad8afb7be
Author: Maxime Ripard <mripard at kernel.org>
Date:   Tue Feb 20 14:12:51 2024 +0100

    drm/i915/tv: Fix TV mode
    
    Commit 1fd4a5a36f9f ("drm/connector: Rename legacy TV property") failed
    to update all the users of the struct drm_tv_connector_state mode field,
    which resulted in a build failure in i915.
    
    However, a subsequent commit in the same series reintroduced a mode
    field in that structure, with a different semantic but the same type,
    with the assumption that all previous users were updated.
    
    Since that didn't happen, the i915 driver now compiles, but mixes
    accesses to the legacy_mode field and the newer mode field, but with the
    previous semantics.
    
    This obviously doesn't work very well, so we need to update the accesses
    that weren't in the legacy renaming commit.
    
    Fixes: 1fd4a5a36f9f ("drm/connector: Rename legacy TV property")
    Reported-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
    Signed-off-by: Maxime Ripard <mripard at kernel.org>
+ /mt/dim checkpatch e2b02e89746d8eff8c244f938eecd0f1db8eb805 drm-intel
34ddcffdb887 drm/i915/tv: Fix TV mode
-:25: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#25: 
Reported-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
Signed-off-by: Maxime Ripard <mripard at kernel.org>

-:73: WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#73: FILE: drivers/gpu/drm/i915/display/intel_sdvo.c:3111:
+	intel_sdvo_connector->base.base.state->tv.legacy_mode = intel_sdvo_connector->tv_format_supported[0];

total: 0 errors, 2 warnings, 0 checks, 80 lines checked