✗ CI.checkpatch: warning for drm/xe: Add helper macro to loop each dss

Patchwork patchwork at emeril.freedesktop.org
Tue Feb 20 16:25:02 UTC 2024


== Series Details ==

Series: drm/xe: Add helper macro to loop each dss
URL   : https://patchwork.freedesktop.org/series/130135/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
35591fb8b4d5305b37ce31483f85ac0956eaa536
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 1bf9b74295de39e85e7be6856b6eda7ae743a90b
Author: Zhanjun Dong <zhanjun.dong at intel.com>
Date:   Tue Feb 20 08:19:37 2024 -0800

    drm/xe: Add helper macro to loop each dss
    
    Add helper macro to loop each dss. This is a precursor patch to allow
    for easier iteration through MCR registers and other per-DSS uses.
    
    Signed-off-by: Zhanjun Dong <zhanjun.dong at intel.com>
+ /mt/dim checkpatch f5141e176ece962a62e4a62df36f32952f85b72d drm-intel
1bf9b74295de drm/xe: Add helper macro to loop each dss
-:97: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dss_' - possible side-effects?
#97: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:39:
+#define for_each_dss_steering(dss_, gt_, group_, instance_) \
+	for (dss_ = xe_gt_topology_get_next_dss(gt_, 0); \
+	     dss_ >= 0; \
+	     dss_ = xe_gt_topology_get_next_dss(gt_, dss_ + 1)) \
+		for_each_if(xe_gt_mcr_get_dss_steering(gt_, dss_, &(group_), &(instance_)))

-:97: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gt_' - possible side-effects?
#97: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:39:
+#define for_each_dss_steering(dss_, gt_, group_, instance_) \
+	for (dss_ = xe_gt_topology_get_next_dss(gt_, 0); \
+	     dss_ >= 0; \
+	     dss_ = xe_gt_topology_get_next_dss(gt_, dss_ + 1)) \
+		for_each_if(xe_gt_mcr_get_dss_steering(gt_, dss_, &(group_), &(instance_)))

-:175: WARNING:NEW_TYPEDEFS: do not add new typedefs
#175: FILE: drivers/gpu/drm/xe/xe_gt_types.h:32:
+typedef unsigned long xe_dss_mask_t[BITS_TO_LONGS(XE_MAX_DSS_FUSE_BITS)];

-:176: WARNING:NEW_TYPEDEFS: do not add new typedefs
#176: FILE: drivers/gpu/drm/xe/xe_gt_types.h:33:
+typedef unsigned long xe_eu_mask_t[BITS_TO_LONGS(XE_MAX_EU_FUSE_BITS)];

total: 0 errors, 2 warnings, 2 checks, 141 lines checked




More information about the Intel-xe mailing list