[PATCH 5/9] rtc: test: Fix invalid format specifier.

Cassio Neri cassio.neri at gmail.com
Wed Feb 21 20:54:34 UTC 2024


Hi David,

Thanks for fixing drivers/rtc/lib_test.c

Best wishes,
Cassio.

On Wed, 21 Feb 2024 at 09:28, David Gow <davidgow at google.com> wrote:

> 'days' is a s64 (from div_s64), and so should use a %lld specifier.
>
> This was found by extending KUnit's assertion macros to use gcc's
> __printf attribute.
>
> Fixes: 1d1bb12a8b18 ("rtc: Improve performance of rtc_time64_to_tm(). Add
> tests.")
> Signed-off-by: David Gow <davidgow at google.com>
> ---
>  drivers/rtc/lib_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/lib_test.c b/drivers/rtc/lib_test.c
> index d5caf36c56cd..225c859d6da5 100644
> --- a/drivers/rtc/lib_test.c
> +++ b/drivers/rtc/lib_test.c
> @@ -54,7 +54,7 @@ static void rtc_time64_to_tm_test_date_range(struct
> kunit *test)
>
>                 days = div_s64(secs, 86400);
>
> -               #define FAIL_MSG "%d/%02d/%02d (%2d) : %ld", \
> +               #define FAIL_MSG "%d/%02d/%02d (%2d) : %lld", \
>                         year, month, mday, yday, days
>
>                 KUNIT_ASSERT_EQ_MSG(test, year - 1900, result.tm_year,
> FAIL_MSG);
> --
> 2.44.0.rc0.258.g7320e95886-goog
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-xe/attachments/20240221/59384278/attachment-0001.htm>


More information about the Intel-xe mailing list