[PATCH 0/4] Refactor xe_exec_queue_create to fix user extensions
Brian Welty
brian.welty at intel.com
Tue Jan 2 21:17:27 UTC 2024
We have an issue in that exec_queue_user_extensions are applied too late.
In the case of USM properties, these need to be set prior to xe_lrc_init().
Split __xe_exec_queue_create() into two functions, alloc and init.
Setting of exec_queue user extensions is moved from the end of the ioctl
function earlier, into __xe_exec_queue_alloc(). This fixes above issue
with USM properties being set too late.
However, in order to apply user extensions this early, we can no longer
call q->ops functions. Instead, make it more efficient. User extension
functions can simply update the q->sched_props values and they will be
applied by the backend during q->ops->init().
Note to reviewers, perhaps review the last patch first.
Brian Welty (4):
drm/xe: Refactor __xe_exec_queue_create()
drm/xe: Add exec_queue.sched_props.job_timeout_ms
drm/xe: Add exec_queue.sched_props.priority
drm/xe: Finish refactoring of exec_queue_create
drivers/gpu/drm/xe/xe_exec_queue.c | 129 ++++++++++++++++-------
drivers/gpu/drm/xe/xe_exec_queue.h | 3 +-
drivers/gpu/drm/xe/xe_exec_queue_types.h | 6 +-
drivers/gpu/drm/xe/xe_gsc.c | 2 +-
drivers/gpu/drm/xe/xe_gt.c | 4 +-
drivers/gpu/drm/xe/xe_guc_submit.c | 10 +-
drivers/gpu/drm/xe/xe_migrate.c | 4 +-
7 files changed, 106 insertions(+), 52 deletions(-)
--
2.43.0
More information about the Intel-xe
mailing list