✗ CI.checkpatch: warning for drm/xe/debugfs: Add support for gt synchronous force reset

Patchwork patchwork at emeril.freedesktop.org
Thu Jan 4 02:27:08 UTC 2024


== Series Details ==

Series: drm/xe/debugfs: Add support for gt synchronous force reset
URL   : https://patchwork.freedesktop.org/series/128088/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
6030b24c1386b00de8187b5fb987e283a57b372a
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 577f84a1952bf4e6fa358c8241a71f12b2e9c973
Author: Karthik Poosa <karthik.poosa at intel.com>
Date:   Sun Dec 31 20:17:33 2023 +0530

    drm/xe/debugfs: Add support for gt synchronous force reset
    
    This support added as igt test freq_reset_multiple fails sporadically
    in case xe_guc_pc is not started.
    A completion is added in force_reset for this.
    Writing non-zero to force_reset debugfs entry does synchronous reset.
    
    v2:
    - Changed wait for completion to interruptible (Anshuman).
    - Moved timeout to xe_gt.h (Anshuman).
    - Created a debugfs for updating timeout (Rodrigo).
    
    v3:
    - Update force_reset debugfs with write support.
      value 0 -> async reset, non-zero -> sync reset (Matthew Brost).
    
    Signed-off-by: Karthik Poosa <karthik.poosa at intel.com>
+ /mt/dim checkpatch 7b3b98d034784b125bad7aca46f9e7a3cfcde45a drm-intel
577f84a19 drm/xe/debugfs: Add support for gt synchronous force reset
-:62: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#62: FILE: drivers/gpu/drm/xe/xe_gt_debugfs.c:68:
+		ret = wait_for_completion_interruptible_timeout(&gt->reset.done,
+							msecs_to_jiffies(gt->reset.timeout_ms));

-:81: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#81: FILE: drivers/gpu/drm/xe/xe_gt_debugfs.c:87:
+	size = min(sizeof(arg_str)-1, len);
 	                          ^

-:133: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#133: FILE: drivers/gpu/drm/xe/xe_gt_debugfs.c:304:
+	gt->reset.fr_dentry = debugfs_create_file("force_reset", 0600, root, xe,
+			    &force_reset_fops);

-:139: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#139: FILE: drivers/gpu/drm/xe/xe_gt_debugfs.c:310:
+	debugfs_create_u32("gt_reset_timeout_ms", 0600, root,
+					&gt->reset.timeout_ms);

total: 0 errors, 0 warnings, 4 checks, 135 lines checked




More information about the Intel-xe mailing list