✗ CI.checkpatch: warning for drm/xe/debugfs: Make sysfs gt force reset synchronous (rev2)

Patchwork patchwork at emeril.freedesktop.org
Thu Jan 4 07:58:23 UTC 2024


== Series Details ==

Series: drm/xe/debugfs: Make sysfs gt force reset synchronous (rev2)
URL   : https://patchwork.freedesktop.org/series/128033/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
6030b24c1386b00de8187b5fb987e283a57b372a
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit c09fe6e720f5c7d541d974c7b95c127d0ae964e3
Author: Karthik Poosa <karthik.poosa at intel.com>
Date:   Wed Dec 27 17:28:20 2023 +0530

    drm/xe/debugfs: Make sysfs gt force reset synchronous
    
    Wait for gt reset to complete before returning from force_reset
    sysfs call. Without this igt test freq_reset_multiple fails
    sporadically in case xe_guc_pc is not started.
    
    v2:
    - Changed wait for completion to interruptible (Anshuman).
    - Moved timeout to xe_gt.h (Anshuman).
    - Created a debugfs for updating timeout (Rodrigo).
    - Moved completion and timeout under gt->reset struct (Badal).
    
    Testcase: igt at xe_guc_pc@freq_reset_multiple
    Signed-off-by: Karthik Poosa <karthik.poosa at intel.com>
+ /mt/dim checkpatch 7b3b98d034784b125bad7aca46f9e7a3cfcde45a drm-intel
c09fe6e72 drm/xe/debugfs: Make sysfs gt force reset synchronous
-:52: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#52: FILE: drivers/gpu/drm/xe/xe_gt_debugfs.c:66:
+	ret = wait_for_completion_interruptible_timeout(&gt->reset.done,
+						msecs_to_jiffies(gt->reset.timeout_ms));

-:67: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#67: FILE: drivers/gpu/drm/xe/xe_gt_debugfs.c:259:
+	debugfs_create_u32("gt_reset_timeout_ms", 0600, root,
+					&gt->reset.timeout_ms);

total: 0 errors, 0 warnings, 2 checks, 56 lines checked




More information about the Intel-xe mailing list