✗ CI.checkpatch: warning for drm/xe: circumvent bogus stringop-overflow warning

Patchwork patchwork at emeril.freedesktop.org
Thu Jan 4 12:45:52 UTC 2024


== Series Details ==

Series: drm/xe: circumvent bogus stringop-overflow warning
URL   : https://patchwork.freedesktop.org/series/128154/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
6030b24c1386b00de8187b5fb987e283a57b372a
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 8b9f73c08069afbae60e83d274d335de45c0baad
Author: Arnd Bergmann <arnd at arndb.de>
Date:   Wed Jan 3 12:48:02 2024 +0100

    drm/xe: circumvent bogus stringop-overflow warning
    
    gcc-13 warns about an array overflow that it sees but that is
    prevented by the "asid % NUM_PF_QUEUE" calculation:
    
    drivers/gpu/drm/xe/xe_gt_pagefault.c: In function 'xe_guc_pagefault_handler':
    include/linux/fortify-string.h:57:33: error: writing 16 bytes into a region of size 0 [-Werror=stringop-overflow=]
    include/linux/fortify-string.h:689:26: note: in expansion of macro '__fortify_memcpy_chk'
      689 | #define memcpy(p, q, s)  __fortify_memcpy_chk(p, q, s,                  \
          |                          ^~~~~~~~~~~~~~~~~~~~
    drivers/gpu/drm/xe/xe_gt_pagefault.c:341:17: note: in expansion of macro 'memcpy'
      341 |                 memcpy(pf_queue->data + pf_queue->tail, msg, len * sizeof(u32));
          |                 ^~~~~~
    drivers/gpu/drm/xe/xe_gt_types.h:102:25: note: at offset [1144, 265324] into destination object 'tile' of size 8
    
    I found that rewriting the assignment using pointer addition rather than the
    equivalent array index calculation prevents the warning, so use that instead.
    
    I sent a bug report against gcc for the false positive warning.
    
    Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
    Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113214
    Signed-off-by: Arnd Bergmann <arnd at arndb.de>
+ /mt/dim checkpatch 7b3b98d034784b125bad7aca46f9e7a3cfcde45a drm-intel
8b9f73c08 drm/xe: circumvent bogus stringop-overflow warning
-:12: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#12: 
  689 | #define memcpy(p, q, s)  __fortify_memcpy_chk(p, q, s,                  \

-:24: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id 'dd08ebf6c352', maybe rebased or not pulled?
#24: 
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")

total: 0 errors, 2 warnings, 0 checks, 8 lines checked




More information about the Intel-xe mailing list