[PATCH v4 5/6] drm/tests: managed: Extract device initialization into test init

[Maxime Ripard]

On Fri, Jan 05, 2024 at 11:13:23AM +0100, Michał Winiarski wrote:
> It simplifies the process of extending the test suite with additional
> test cases without unnecessary duplication.
> 
> Signed-off-by: Michał Winiarski <michal.winiarski at intel.com>
> ---
>  drivers/gpu/drm/tests/drm_managed_test.c | 37 +++++++++++++++---------
>  1 file changed, 24 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tests/drm_managed_test.c b/drivers/gpu/drm/tests/drm_managed_test.c
> index 986a38c9144a5..c1fc1f0aac9b2 100644
> --- a/drivers/gpu/drm/tests/drm_managed_test.c
> +++ b/drivers/gpu/drm/tests/drm_managed_test.c
> @@ -9,6 +9,7 @@
>  #include <linux/device.h>
>  
>  struct managed_test_priv {
> +	struct drm_device *drm;
>  	bool action_done;
>  };
>  
> @@ -24,11 +25,26 @@ static void drm_action(struct drm_device *drm, void *ptr)
>   * device is released.
>   */
>  static void drm_test_managed_run_action(struct kunit *test)
> +{
> +	struct managed_test_priv *priv = test->priv;
> +	int ret;
> +
> +	ret = drmm_add_action_or_reset(priv->drm, drm_action, priv);
> +	KUNIT_EXPECT_EQ(test, ret, 0);
> +
> +	ret = drm_dev_register(priv->drm, 0);
> +	KUNIT_ASSERT_EQ(test, ret, 0);
> +
> +	drm_dev_unregister(priv->drm);
> +	drm_kunit_helper_free_device(test, priv->drm->dev);
> +
> +	KUNIT_EXPECT_TRUE_MSG(test, priv->action_done, "Release action was not called");

Aside from the message here I already pointed out,

Acked-by: Maxime Ripard <mripard at kernel.org>

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-xe/attachments/20240108/80143451/attachment-0001.sig>