[PATCH 3/4] drm/xe: Annotate multiple mmio pointers with __iomem

Lucas De Marchi lucas.demarchi at intel.com
Tue Jan 9 14:53:58 UTC 2024


On Tue, Jan 09, 2024 at 12:24:04PM +0100, Thomas Hellström wrote:
>There are a couple of pointers pointing to MMIO space. Annotate them
>with __iomem and fix the corresponding sparse warnings.
>
>Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
>Fixes: 3b0d4a557996 ("drm/xe: Move register MMIO into xe_tile")
>Fixes: 399a13323f0d ("drm/xe: add 28-bit address support in struct xe_reg")
>Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
>Cc: Matthew Brost <matthew.brost at intel.com>
>Cc: Lucas De Marchi <lucas.demarchi at intel.com>
>Cc: Matt Roper <matthew.d.roper at intel.com>
>Cc: Koby Elbaz <kelbaz at habana.ai>
>Cc: Ofir Bitton <obitton at habana.ai>
>Cc: Moti Haimovski <mhaimovski at habana.ai>
>Signed-off-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi

>---
> drivers/gpu/drm/xe/xe_device_types.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
>index 171e8615d184..e0da2e3ca426 100644
>--- a/drivers/gpu/drm/xe/xe_device_types.h
>+++ b/drivers/gpu/drm/xe/xe_device_types.h
>@@ -147,7 +147,7 @@ struct xe_tile {
> 		size_t size;
>
> 		/** @regs: pointer to tile's MMIO space (starting with registers) */
>-		void *regs;
>+		void __iomem *regs;
> 	} mmio;
>
> 	/**
>@@ -160,7 +160,7 @@ struct xe_tile {
> 		size_t size;
>
> 		/** @regs: pointer to tile's additional MMIO-extension space */
>-		void *regs;
>+		void __iomem *regs;
> 	} mmio_ext;
>
> 	/** @mem: memory management info for tile */
>@@ -306,7 +306,7 @@ struct xe_device {
> 		/** @size: size of MMIO space for device */
> 		size_t size;
> 		/** @regs: pointer to MMIO space for device */
>-		void *regs;
>+		void __iomem *regs;
> 	} mmio;
>
> 	/** @mem: memory info for device */
>-- 
>2.43.0
>


More information about the Intel-xe mailing list