✗ CI.checkpatch: warning for drm/xe/migrate: Fix CCS copy for small VRAM copy chunks (rev5)
Patchwork
patchwork at emeril.freedesktop.org
Wed Jan 10 19:03:10 UTC 2024
== Series Details ==
Series: drm/xe/migrate: Fix CCS copy for small VRAM copy chunks (rev5)
URL : https://patchwork.freedesktop.org/series/127874/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
414601bf14e77eeb048ecf6d1c25190801399524
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 1de4ec48ca8f32d7263613740b9fd72ce29928e9
Author: Thomas Hellström <thomas.hellstrom at linux.intel.com>
Date: Wed Jan 10 17:34:15 2024 +0100
drm/xe/migrate: Fix CCS copy for small VRAM copy chunks
Since the migrate code is using the identity map for addressing VRAM,
copy chunks may become as small as 64K if the VRAM resource is fragmented.
However, a chunk size smaller that 1MiB may lead to the *next* chunk's
offset into the CCS metadata backup memory may not be page-aligned, and
the XY_CTRL_SURF_COPY_BLT command can't handle that, and even if it could,
the current code doesn't handle the offset calculaton correctly.
To fix this, make sure we align the size of VRAM copy chunks to 1MiB. If
the remaining data to copy is smaller than that, that's not a problem,
so use the remaining size. If the VRAM copy cunk becomes fragmented due
to the size alignment restriction, don't use the identity map, but instead
emit PTEs into the page-table like we do for system memory.
v2:
- Rebase
v3:
- Future proof somewhat by taking into account the real data size to
flat CCS metadata size ratio. (Matt Roper)
- Invert a couple of if-statements for better readability.
- Fix support for 4K-granularity VRAM sizes. (Tested on DG1).
v4:
- Fix up code comments
- Fix debug printout format typo.
v5:
- Add a Fixes: tag.
Cc: Matt Roper <matthew.d.roper at intel.com>
Cc: Matthew Auld <matthew.william.auld at gmail.com>
Cc: Matthew Brost <matthew.brost at intel.com>
Fixes: e89b384cde62 ("drm/xe/migrate: Update emit_pte to cope with a size level than 4k")
Signed-off-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>
+ /mt/dim checkpatch bb9e8031d2feb59becdea41e54e62f1bc47f3ef9 drm-intel
1de4ec48c drm/xe/migrate: Fix CCS copy for small VRAM copy chunks
-:39: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id 'e89b384cde62', maybe rebased or not pulled?
#39:
Fixes: e89b384cde62 ("drm/xe/migrate: Update emit_pte to cope with a size level than 4k")
total: 0 errors, 1 warnings, 0 checks, 229 lines checked
More information about the Intel-xe
mailing list