✗ CI.checkpatch: warning for drm/i915/display: DMC wakelock implementation

Patchwork patchwork at emeril.freedesktop.org
Thu Jan 11 09:56:08 UTC 2024


== Series Details ==

Series: drm/i915/display: DMC wakelock implementation
URL   : https://patchwork.freedesktop.org/series/128628/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
faa12d3432d7ef7793d934cd9338c555e95a5aad
+ git -C mt rev-list -n1 origin/master
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit eaa070e2a4f2837e693e2a733464be819a8c0bae
Author: Luca Coelho <luciano.coelho at intel.com>
Date:   Thu Jan 11 11:16:22 2024 +0200

    drm/i915/display: use wakelock in the last write function
    
    Finally, add the wakelock mechanism to the write functions.
    
    Signed-off-by: Luca Coelho <luciano.coelho at intel.com>
+ /mt/dim checkpatch 79184e72263e91528195db01783148435c7e4fad drm-intel
a737a7afb drm/i915/display: add support for DMC wakelocks
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:113: CHECK:LINE_SPACING: Please don't use multiple blank lines
#113: FILE: drivers/gpu/drm/i915/display/intel_display_core.h:530:
+
+

-:157: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#157: 
new file mode 100644

-:162: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/gpu/drm/i915/display/intel_wakelock.c', please use '//' instead
#162: FILE: drivers/gpu/drm/i915/display/intel_wakelock.c:1:
+/* SPDX-License-Identifier: MIT */

-:162: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#162: FILE: drivers/gpu/drm/i915/display/intel_wakelock.c:1:
+/* SPDX-License-Identifier: MIT */

-:213: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#213: FILE: drivers/gpu/drm/i915/display/intel_wakelock.c:52:
+	udelay(100);

-:279: WARNING:RETURN_VOID: void function return statements are not generally useful
#279: FILE: drivers/gpu/drm/i915/display/intel_wakelock.c:118:
+	return;
+}

-:316: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#316: FILE: drivers/gpu/drm/i915/display/intel_wakelock.c:155:
+	udelay(100);

-:376: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#376: FILE: drivers/gpu/drm/i915/display/intel_wakelock.h:18:
+	spinlock_t lock;

total: 0 errors, 4 warnings, 4 checks, 327 lines checked
8915e9cf2 drm/i915/display: use wakelock in the remaining read operations
41dfc520e drm/i915/display: use wakelock in register waiting functions
-:6: WARNING:TYPO_SPELLING: 'functonality' may be misspelled - perhaps 'functionality'?
#6: 
Add the wakelock functonality to the functions that help wait for
                 ^^^^^^^^^^^^

total: 0 errors, 1 warnings, 0 checks, 82 lines checked
eaa070e2a drm/i915/display: use wakelock in the last write function




More information about the Intel-xe mailing list