✗ CI.checkpatch: warning for series starting with [1/4] drm/xe: Add uapi for dumpable bos

Patchwork patchwork at emeril.freedesktop.org
Fri Jan 12 13:23:04 UTC 2024


== Series Details ==

Series: series starting with [1/4] drm/xe: Add uapi for dumpable bos
URL   : https://patchwork.freedesktop.org/series/128717/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
faa12d3432d7ef7793d934cd9338c555e95a5aad
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 78b7a59ac3a58ddea1ebb8cc14a6982b263aa9df
Author: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Date:   Fri Jan 12 13:41:48 2024 +0100

    drm/xe: Implement VM snapshot support for BO's and userptr
    
    Since we cannot immediately capture the BO's and userptr, perform it in
    2 stages. The immediate stage takes a reference to each BO and userptr,
    while a delayed worker captures the contents and then frees the
    reference.
    
    This is required because in signaling context, no locks can be taken, no
    memory can be allocated, and no waits on userspace can be performed.
    
    With the delayed worker, all of this can be performed very easily,
    without having to resort to hacks.
    
    Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
+ /mt/dim checkpatch 7a20187068bed91b523795a18219e570f1e84eb1 drm-intel
bb584db28 drm/xe: Add uapi for dumpable bos
c6bcab073 drm/xe: Annotate each dumpable vma as such
6b0d6095d drm/xe: Add vm snapshot mutex for easily taking a vm snapshot during devcoredump
78b7a59ac drm/xe: Implement VM snapshot support for BO's and userptr
-:149: WARNING:TYPO_SPELLING: 'deffered' may be misspelled - perhaps 'deferred'?
#149: FILE: drivers/gpu/drm/xe/xe_devcoredump_types.h:32:
+	/** @work: Workqueue for deffered capture outside of signaling context */
 	                         ^^^^^^^^

-:176: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u64' over 'uint64_t'
#176: FILE: drivers/gpu/drm/xe/xe_vm.c:3236:
+		uint64_t ofs, bo_ofs;

-:262: WARNING:LINE_SPACING: Missing a blank line after declarations
#262: FILE: drivers/gpu/drm/xe/xe_vm.c:3322:
+			void __user *userptr = (void __user *)(size_t)snap->snap[i].bo_ofs;
+			kthread_use_mm(snap->snap[i].mm);

-:293: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#293: FILE: drivers/gpu/drm/xe/xe_vm.c:3353:
+			uint32_t *x = snap->snap[i].data + j;

-:296: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#296: FILE: drivers/gpu/drm/xe/xe_vm.c:3356:
+				   snap->snap[i].ofs + j, x[0], x[1], x[2], x[3], x[4], x[5], x[6], x[7],

total: 0 errors, 3 warnings, 2 checks, 285 lines checked




More information about the Intel-xe mailing list