[PATCH] drm/xe: Remove obsolete async_ops from struct xe_vm
Francois Dugast
francois.dugast at intel.com
Tue Jan 16 08:46:07 UTC 2024
Hi Mika,
On Mon, Jan 15, 2024 at 06:01:13PM +0200, Mika Kuoppala wrote:
> Commit f3e9b1f43458 ("drm/xe: Remove async worker and rework sync binds")
> made async_ops in struct xe_vm obsolete but forgot to remove it.
>
> Signed-off-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
It seems a reference to this commit should be added in your commit
message as "Fixes: ". With this:
Reviewed-by: Francois Dugast <francois.dugast at intel.com>
Francois
> ---
> drivers/gpu/drm/xe/xe_vm_types.h | 24 ------------------------
> 1 file changed, 24 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_vm_types.h b/drivers/gpu/drm/xe/xe_vm_types.h
> index 63e8a50b88e9..b0357fa282b8 100644
> --- a/drivers/gpu/drm/xe/xe_vm_types.h
> +++ b/drivers/gpu/drm/xe/xe_vm_types.h
> @@ -180,30 +180,6 @@ struct xe_vm {
> */
> struct xe_range_fence_tree rftree[XE_MAX_TILES_PER_DEVICE];
>
> - /** @async_ops: async VM operations (bind / unbinds) */
> - struct {
> - /** @list: list of pending async VM ops */
> - struct list_head pending;
> - /** @work: worker to execute async VM ops */
> - struct work_struct work;
> - /** @lock: protects list of pending async VM ops and fences */
> - spinlock_t lock;
> - /** @fence: fence state */
> - struct {
> - /** @context: context of async fence */
> - u64 context;
> - /** @seqno: seqno of async fence */
> - u32 seqno;
> - } fence;
> - /** @error: error state for async VM ops */
> - int error;
> - /**
> - * @munmap_rebind_inflight: an munmap style VM bind is in the
> - * middle of a set of ops which requires a rebind at the end.
> - */
> - bool munmap_rebind_inflight;
> - } async_ops;
> -
> const struct xe_pt_ops *pt_ops;
>
> /** @userptr: user pointer state */
> --
> 2.34.1
>
More information about the Intel-xe
mailing list