[PATCH] drm/xe: Fix typo in vram frequency sysfs documentation

Lucas De Marchi lucas.demarchi at intel.com
Tue Jan 16 17:06:34 UTC 2024


On Tue, Jan 16, 2024 at 03:39:54PM +0530, Sujaritha Sundaresan wrote:
>
>On 1/11/2024 2:13 AM, Lucas De Marchi wrote:
>>On Wed, Jan 10, 2024 at 01:12:03PM +0530, Sujaritha Sundaresan wrote:
>>>Fix function naming and description for xe_vram_freq_sysfs_init
>>>function.
>>>
>>>Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan at intel.com>
>>>---
>>>drivers/gpu/drm/xe/xe_vram_freq.c | 2 +-
>>>1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>>diff --git a/drivers/gpu/drm/xe/xe_vram_freq.c 
>>>b/drivers/gpu/drm/xe/xe_vram_freq.c
>>>index 733146293307..838f582e5632 100644
>>>--- a/drivers/gpu/drm/xe/xe_vram_freq.c
>>>+++ b/drivers/gpu/drm/xe/xe_vram_freq.c
>>>@@ -96,7 +96,7 @@ static void vram_freq_sysfs_fini(struct 
>>>drm_device *drm, void *arg)
>>>}
>>>
>>>/*
>>
>>should be /** to make this kernel-doc, too?
>Sure will fix this.
>>
>>>- * xe_vram_freq_init - Initialize vram frequency component
>>>+ * xe_vram_freq_sysfs_init - Initialize vram frequency sysfs component
>>> * @tile: Xe Tile object
>>> *
>>> * It needs to be initialized after the main tile component is ready
>>
>>there's a trailing list after this comment that should be removed too.
>>
>>thanks
>>
>>Lucas De Marchi
>
>What's the trailing list ? Didn't get this. Could you clarify this a bit ?

sorry, s/list/line/


	/*
	 * xe_vram_freq_init - Initialize vram frequency component
	 * @tile: Xe Tile object
	 *
	 * It needs to be initialized after the main tile component is ready
	 */
this -->
	void xe_vram_freq_sysfs_init(struct xe_tile *tile)


Lucas De Marchi


More information about the Intel-xe mailing list