✗ CI.checkpatch: warning for drm/xe: correct the calculation of remaining size

Patchwork patchwork at emeril.freedesktop.org
Wed Jan 17 21:37:38 UTC 2024


== Series Details ==

Series: drm/xe: correct the calculation of remaining size
URL   : https://patchwork.freedesktop.org/series/128844/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
e7f730565356938dd6c63cd498218fdc5d6a22b0
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit faa257594f90e3056b10efd15f2f90105fad937b
Author: Fei Yang <fei.yang at intel.com>
Date:   Tue Jan 16 11:52:51 2024 -0800

    drm/xe: correct the calculation of remaining size
    
    In function write_pgtable, the calculation of chunk in the do-while
    loop is wrong, we should always compare against remaining size instead
    of the total size update->qwords.
    Also, when performing dword writes, dword length can be any value
    from 2 to 3fe, always adding 1 is wrong.
    
    Signed-off-by: Fei Yang <fei.yang at intel.com>
+ /mt/dim checkpatch 6002d529f9fe420895d407e481d39b19b58ec001 drm-intel
faa257594 drm/xe: correct the calculation of remaining size
-:23: ERROR:SPACING: spaces required around that '?' (ctx:VxW)
#23: FILE: drivers/gpu/drm/xe/instructions/xe_mi_commands.h:39:
+#define   MI_SDI_NUM_DW(x)		REG_FIELD_PREP(MI_SDI_LEN_DW, (x > 1)? x : 2)
                           		                                     ^

-:23: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#23: FILE: drivers/gpu/drm/xe/instructions/xe_mi_commands.h:39:
+#define   MI_SDI_NUM_DW(x)		REG_FIELD_PREP(MI_SDI_LEN_DW, (x > 1)? x : 2)

-:23: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues
#23: FILE: drivers/gpu/drm/xe/instructions/xe_mi_commands.h:39:
+#define   MI_SDI_NUM_DW(x)		REG_FIELD_PREP(MI_SDI_LEN_DW, (x > 1)? x : 2)

total: 1 errors, 0 warnings, 2 checks, 16 lines checked




More information about the Intel-xe mailing list