[PATCH 3/6] drm/xe: Mark VF accessible GuC registers

Matt Roper matthew.d.roper at intel.com
Wed Jan 17 23:26:27 UTC 2024


On Tue, Jan 16, 2024 at 03:56:14PM +0100, Michal Wajdeczko wrote:
> Only selected registers are available for Virtual Functions.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>

It took me a bit of hunting in the spec, but I finally figured out that
folder 53221 is where we can find the list of VF-accessible registers.
It might be worth adding a bspec reference for that since it seems like
a non-obvious location.

Bspec: 53221
Reviewed-by: Matt Roper <matthew.d.roper at intel.com>

> ---
>  drivers/gpu/drm/xe/regs/xe_guc_regs.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/regs/xe_guc_regs.h b/drivers/gpu/drm/xe/regs/xe_guc_regs.h
> index 92320bbc9d3d..71a78a486ac0 100644
> --- a/drivers/gpu/drm/xe/regs/xe_guc_regs.h
> +++ b/drivers/gpu/drm/xe/regs/xe_guc_regs.h
> @@ -100,14 +100,14 @@
>  #define GT_PM_CONFIG				XE_REG(0x13816c)
>  #define   GT_DOORBELL_ENABLE			REG_BIT(0)
>  
> -#define GUC_HOST_INTERRUPT			XE_REG(0x1901f0)
> +#define GUC_HOST_INTERRUPT			XE_REG(0x1901f0, XE_REG_OPTION_VF)
>  
> -#define VF_SW_FLAG(n)				XE_REG(0x190240 + (n) * 4)
> +#define VF_SW_FLAG(n)				XE_REG(0x190240 + (n) * 4, XE_REG_OPTION_VF)
>  #define VF_SW_FLAG_COUNT			4
>  
> -#define MED_GUC_HOST_INTERRUPT			XE_REG(0x190304)
> +#define MED_GUC_HOST_INTERRUPT			XE_REG(0x190304, XE_REG_OPTION_VF)
>  
> -#define MED_VF_SW_FLAG(n)			XE_REG(0x190310 + (n) * 4)
> +#define MED_VF_SW_FLAG(n)			XE_REG(0x190310 + (n) * 4, XE_REG_OPTION_VF)
>  #define MED_VF_SW_FLAG_COUNT			4
>  
>  /* GuC Interrupt Vector */
> -- 
> 2.25.1
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation


More information about the Intel-xe mailing list