[PATCH] drm/xe/debugfs: Expose debugfs entry to check guc pc support

[Gupta, Anshuman]

> -----Original Message-----
> From: Nilawar, Badal <badal.nilawar at intel.com>
> Sent: Friday, January 19, 2024 3:01 PM
> To: Gupta, Anshuman <anshuman.gupta at intel.com>; intel-
> xe at lists.freedesktop.org
> Cc: Vivi, Rodrigo <rodrigo.vivi at intel.com>; Roper, Matthew D
> <matthew.d.roper at intel.com>; Dixit, Ashutosh <ashutosh.dixit at intel.com>;
> Belgaumkar, Vinay <vinay.belgaumkar at intel.com>
> Subject: Re: [PATCH] drm/xe/debugfs: Expose debugfs entry to check guc pc
> support
> 
> 
> 
> On 19-01-2024 14:58, Gupta, Anshuman wrote:
> >
> >
> >> -----Original Message-----
> >> From: Nilawar, Badal <badal.nilawar at intel.com>
> >> Sent: Friday, January 19, 2024 1:49 PM
> >> To: intel-xe at lists.freedesktop.org
> >> Cc: Gupta, Anshuman <anshuman.gupta at intel.com>; Vivi, Rodrigo
> >> <rodrigo.vivi at intel.com>; Roper, Matthew D
> >> <matthew.d.roper at intel.com>; Dixit, Ashutosh
> >> <ashutosh.dixit at intel.com>; Belgaumkar, Vinay
> >> <vinay.belgaumkar at intel.com>
> >> Subject: [PATCH] drm/xe/debugfs: Expose debugfs entry to check guc pc
> >> support
> >>
> >> Expose debugfs entry to check if platform support GuC PC (SLPC) feature.
> >>
> >> Signed-off-by: Badal Nilawar <badal.nilawar at intel.com>
> >> ---
> >>   drivers/gpu/drm/xe/xe_debugfs.c | 8 ++++++++
> >>   1 file changed, 8 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/xe/xe_debugfs.c
> >> b/drivers/gpu/drm/xe/xe_debugfs.c index c56fd7d59f05..2f474bf0e7c7
> >> 100644
> >> --- a/drivers/gpu/drm/xe/xe_debugfs.c
> >> +++ b/drivers/gpu/drm/xe/xe_debugfs.c
> >> @@ -30,6 +30,13 @@ static struct xe_device *node_to_xe(struct
> >> drm_info_node *node)
> >>   	return to_xe_device(node->minor->dev);  }
> >>
> >> +static int is_gucpc_supported(struct seq_file *m, void *data) {
> >> +	struct xe_device *xe = node_to_xe(m->private);
> >> +
> >> +	return (int)!xe->info.skip_guc_pc;
> >> +}
> >> +
> >>   static int info(struct seq_file *m, void *data)  {
> >>   	struct xe_device *xe = node_to_xe(m->private); @@ -67,6 +74,7 @@
> >> static int info(struct seq_file *m, void *data)
> >>
> >>   static const struct drm_info_list debugfs_list[] = {
> >>   	{"info", info, 0},
> >> +	{"is_gucpc_supported", is_gucpc_supported, 0},
> > Above debugfs is per device.
> > We need this debugfs for each gt.
> The field skip_guc_pc is device specific so kept debugfs device specific.
That make sense but then it is better to have a print in existing info debugfs 
as this is filed in xe->info ?
From igt we can grep the skip_guc_pc either "Yes" or "No".
Thanks,
Anshuman.

> 
> Regards,
> Badal
> > Thanks,
> > Anshuman.
> >>   };
> >>
> >>   static int forcewake_open(struct inode *inode, struct file *file)
> >> --
> >> 2.25.1
> >