✗ CI.checkpatch: warning for Revert "drm/xe/uc: Store firmware binary in system-memory backed BO"
Patchwork
patchwork at emeril.freedesktop.org
Fri Jan 19 14:16:14 UTC 2024
== Series Details ==
Series: Revert "drm/xe/uc: Store firmware binary in system-memory backed BO"
URL : https://patchwork.freedesktop.org/series/128981/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
e7f730565356938dd6c63cd498218fdc5d6a22b0
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 447f64d901ff32c29e0d47a994910e9cb2b7d785
Author: Rodrigo Vivi <rodrigo.vivi at intel.com>
Date: Fri Jan 19 08:25:48 2024 -0500
Revert "drm/xe/uc: Store firmware binary in system-memory backed BO"
This reverts commit 48cd5ebcb645ac1bd48480cf11dced902108d306.
This is breaking the GuC load after suspend cycles where the
power was lost such as s3 and d3cold on DGFX.
xe 0000:03:00.0: [drm] GuC load failed: status = 0x400000A0
xe 0000:03:00.0: [drm] GuC load failed: status: Reset = 0,
BootROM = 0x50, UKernel = 0x00, MIA = 0x00, Auth = 0x01
Currently our suspend/resume flows only evict and restore the BOs
living in the VRAM itself since the system memory power won't be
lost. However, it seems that we might lose the PTEs for those
entries. While we don't have that in place, let's ensure that we
keep uc images in VRAM if possible.
Also another concern is the impact in the resume latency of
this case. So I wonder that if we end up moving this
uc_fw_copy to an earlier stage where LMEM is really not yet
available, maybe we need to later switch the uc_fw->bo to
a VRAM for the final access and better resume times.
Cc: Michał Winiarski <michal.winiarski at intel.com>
Cc: Matt Roper <matthew.d.roper at intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
+ /mt/dim checkpatch 873aee20af09054189670092b2d6fe03824777b5 drm-intel
447f64d90 Revert "drm/xe/uc: Store firmware binary in system-memory backed BO"
-:10: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '48cd5ebcb645ac1bd48480cf11dced902108d306', maybe rebased or not pulled?
#10:
This reverts commit 48cd5ebcb645ac1bd48480cf11dced902108d306.
total: 0 errors, 1 warnings, 0 checks, 16 lines checked
More information about the Intel-xe
mailing list