[PATCH 03/17] drm/xe/oa/uapi: Add oa_max_sample_rate sysctl

[Dixit, Ashutosh]

On Wed, 13 Dec 2023 16:58:52 -0800, Umesh Nerlige Ramappa wrote:
>
> > --- a/drivers/gpu/drm/xe/xe_device.c
> > +++ b/drivers/gpu/drm/xe/xe_device.c
> > @@ -29,6 +29,7 @@
> > #include "xe_irq.h"
> > #include "xe_mmio.h"
> > #include "xe_module.h"
> > +#include "xe_oa.h"
> > #include "xe_pat.h"
> > #include "xe_pcode.h"
> > #include "xe_perf.h"
> > @@ -480,6 +481,10 @@ int xe_device_probe(struct xe_device *xe)
> >
> >	xe_heci_gsc_init(xe);
> >
> > +	err = xe_oa_init(xe);
> > +	if (err)
> > +		goto err_irq_shutdown;
> > +
> >	err = xe_display_init(xe);
> >	if (err)
> >		goto err_irq_shutdown;
>
> ^ this needs to do an xe_oa_fini on failure, so should be a different/new
> goto label.

Good point, fixed in v8. Though the "drm/xe/oa/uapi: Add oa_max_sample_rate
sysctl" patch is gone in v8, so the change has been made in
"drm/xe/oa/uapi: Add OA data formats".