[PATCH 1/9] drm/xe: Remove double new line in devcoredump

[Summers, Stuart]

On Mon, 2024-01-22 at 09:04 -0800, José Roberto de Souza wrote:
> Right now devcoredump has a new line between '**** GuC CT ****' and
> 'H2G CTB (all sizes in DW):' while other sections don't have.
> 
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Maarten Lankhorst <dev at lankhorst.se>
> Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc_ct.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c
> b/drivers/gpu/drm/xe/xe_guc_ct.c
> index ee5d99456aebc..0c07355690948 100644
> --- a/drivers/gpu/drm/xe/xe_guc_ct.c
> +++ b/drivers/gpu/drm/xe/xe_guc_ct.c
> @@ -1366,7 +1366,7 @@ void xe_guc_ct_snapshot_print(struct
> xe_guc_ct_snapshot *snapshot,
>                 return;
>  
>         if (snapshot->ct_enabled) {
> -               drm_puts(p, "\nH2G CTB (all sizes in DW):\n");
> +               drm_puts(p, "H2G CTB (all sizes in DW):\n");
>                 guc_ctb_snapshot_print(&snapshot->h2g, p);
>  
>                 drm_puts(p, "\nG2H CTB (all sizes in DW):\n");

Why not here too?

Also just visually IMO it is nice to have the extra spacing here. I
don't have a strong opinion though.

Thanks,
Stuart

> @@ -1375,7 +1375,7 @@ void xe_guc_ct_snapshot_print(struct
> xe_guc_ct_snapshot *snapshot,
>                 drm_printf(p, "\tg2h outstanding: %d\n",
>                            snapshot->g2h_outstanding);
>         } else {
> -               drm_puts(p, "\nCT disabled\n");
> +               drm_puts(p, "CT disabled\n");
>         }
>  }
>