✗ CI.checkpatch: warning for series starting with [1/4] drm/xe: Add uapi for dumpable bos, v2.

Patchwork patchwork at emeril.freedesktop.org
Wed Jan 24 17:07:36 UTC 2024


== Series Details ==

Series: series starting with [1/4] drm/xe: Add uapi for dumpable bos, v2.
URL   : https://patchwork.freedesktop.org/series/129136/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
b2ca823f819193c33ab811dfac08c614138d6d46
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 0f63e7815ec8b53be5e36fbf120bc7c76fe5b39e
Author: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Date:   Wed Jan 24 17:52:45 2024 +0100

    drm/xe: Implement VM snapshot support for BO's and userptr, v2.
    
    Since we cannot immediately capture the BO's and userptr, perform it in
    2 stages. The immediate stage takes a reference to each BO and userptr,
    while a delayed worker captures the contents and then frees the
    reference.
    
    This is required because in signaling context, no locks can be taken, no
    memory can be allocated, and no waits on userspace can be performed.
    
    With the delayed worker, all of this can be performed very easily,
    without having to resort to hacks.
    
    Changes since v1:
    - Fix crash on NULL captured vm.
    - Use ascii85_encode to capture BO contents and save some space. (Jose
      Souza)
    - Add length to coredump output for each captured area.
    
    Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
+ /mt/dim checkpatch 96b582d5ddfc0770491b81522c6c9bba7d0aef86 drm-intel
343e6dc3c drm/xe: Add uapi for dumpable bos, v2.
01e238a4b drm/xe: Annotate each dumpable vma as such
74f6d3d73 drm/xe: Add vm snapshot mutex for easily taking a vm snapshot during devcoredump
0f63e7815 drm/xe: Implement VM snapshot support for BO's and userptr, v2.
-:154: WARNING:TYPO_SPELLING: 'deffered' may be misspelled - perhaps 'deferred'?
#154: FILE: drivers/gpu/drm/xe/xe_devcoredump_types.h:32:
+	/** @work: Workqueue for deffered capture outside of signaling context */
 	                         ^^^^^^^^

-:189: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u64' over 'uint64_t'
#189: FILE: drivers/gpu/drm/xe/xe_vm.c:3245:
+		uint64_t ofs, bo_ofs;

-:281: WARNING:LINE_SPACING: Missing a blank line after declarations
#281: FILE: drivers/gpu/drm/xe/xe_vm.c:3337:
+			void __user *userptr = (void __user *)(size_t)snap->snap[i].bo_ofs;
+			kthread_use_mm(snap->snap[i].mm);

-:314: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#314: FILE: drivers/gpu/drm/xe/xe_vm.c:3370:
+			uint32_t *val = snap->snap[i].data + j;

-:317: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#317: FILE: drivers/gpu/drm/xe/xe_vm.c:3373:
+			uint32_t k;

-:323: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#323: FILE: drivers/gpu/drm/xe/xe_vm.c:3379:
+				   snap->snap[i].ofs + j, x[0], x[1], x[2], x[3], x[4], x[5], x[6], x[7],

total: 0 errors, 3 warnings, 3 checks, 307 lines checked




More information about the Intel-xe mailing list