[PATCH] drm/xe/xe_guc: Reduce a print from warn to debug

Lucas De Marchi lucas.demarchi at intel.com
Thu Jan 25 16:36:33 UTC 2024


On Thu, Jan 25, 2024 at 09:16:47PM +0530, Karthik Poosa wrote:
>Reduce debug print from warn to debug to avoid uncessary
>warning message in dmesg (Lucas).
>
>Fixes: c5a06c9169f3 ("drm/xe/guc: Enable WA 14018913170")
>Signed-off-by: Karthik Poosa <karthik.poosa at intel.com>
>---
> drivers/gpu/drm/xe/xe_guc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
>index 576ff2c1fbb9..6fbeddc557af 100644
>--- a/drivers/gpu/drm/xe/xe_guc.c
>+++ b/drivers/gpu/drm/xe/xe_guc.c
>@@ -174,7 +174,7 @@ static u32 guc_ctl_wa_flags(struct xe_guc *guc)
> 		if (GUC_VER(version->major, version->minor, version->patch) >= GUC_VER(70, 7, 0))
> 			flags |= GUC_WA_ENABLE_TSC_CHECK_ON_RC6;
> 		else
>-			drm_warn(&xe->drm, "can't apply WA 14018913170, GUC version expected >= 70.7.0, found %u %u %u\n",
>+			drm_dbg(&xe->drm, "can't apply WA 14018913170, GUC version expected >= 70.7.0, found %u %u %u\n",
> 				 version->major, version->minor, version->patch);

do we even need a debug message here?  Once we upgrade the GuC version,
we will have a message already with the right priority that fw
should/could be upgraded.

I didn't follow exactly how this WA got added, but... does the older GuC
fail if the flag is passed? Otherwise, can we simply ignore the version
check and pass it unconditionally?


Lucas De Marchi

> 	}
>
>-- 
>2.25.1
>


More information about the Intel-xe mailing list