[PATCH] drm/xe/xe_guc: Reduce a print from warn to debug

Summers, Stuart stuart.summers at intel.com
Thu Jan 25 18:10:52 UTC 2024


On Thu, 2024-01-25 at 22:26 +0530, Karthik Poosa wrote:
> Reduce debug print from warn to debug to avoid uncessary
> warning message in dmesg (Lucas).
> 
> Fixes: c5a06c9169f3 ("drm/xe/guc: Enable WA 14018913170")
> Suggested-by: Lucas De Marchi <lucas.demarchi at intel.com>
> Signed-off-by: Karthik Poosa <karthik.poosa at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc.c
> b/drivers/gpu/drm/xe/xe_guc.c
> index 576ff2c1fbb9..f4e555611baa 100644
> --- a/drivers/gpu/drm/xe/xe_guc.c
> +++ b/drivers/gpu/drm/xe/xe_guc.c
> @@ -174,8 +174,8 @@ static u32 guc_ctl_wa_flags(struct xe_guc *guc)
>                 if (GUC_VER(version->major, version->minor, version-
> >patch) >= GUC_VER(70, 7, 0))
>                         flags |= GUC_WA_ENABLE_TSC_CHECK_ON_RC6;
>                 else
> -                       drm_warn(&xe->drm, "can't apply WA
> 14018913170, GUC version expected >= 70.7.0, found %u %u %u\n",
> -                                version->major, version->minor,
> version->patch);
> +                       drm_dbg(&xe->drm, "can't apply WA
> 14018913170, GUC version expected >= 70.7.0, found %u %u %u\n",
> +                               version->major, version->minor,
> version->patch);

It would be nice if we had a more programmatic way to handle
workarounds that have a specific GuC requirement so they can all use
the same print message. Obviously not required here though.

Reviewed-by: Stuart Summers <stuart.summers at intel.com>

>         }
>  
>         return flags;



More information about the Intel-xe mailing list