✗ CI.checkpatch: warning for drm/xe/display: Fix memleak in display initialization (rev2)

[Patchwork]

== Series Details ==

Series: drm/xe/display: Fix memleak in display initialization (rev2)
URL   : https://patchwork.freedesktop.org/series/129150/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
2d919ac662b2798c053d68d1cc16b758c61b55ca
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit f8c2c6b7ec2f2742b21b765dce8b3945197fddae
Author: wangxiaoming321 <xiaoming.wang at intel.com>
Date:   Fri Jan 26 22:34:33 2024 +0800

    drm/xe/display: Fix memleak in display initialization
    
    intel_power_domains_init has been called twice in xe_device_probe:
    xe_device_probe -> xe_display_init_nommio -> intel_power_domains_init(xe)
    xe_device_probe -> xe_display_init_noirq -> intel_display_driver_probe_noirq
    -> intel_power_domains_init(i915)
    
    It needs add a flag to avoid power_domains->power_wells double malloc.
    
    unreferenced object 0xffff88811150ee00 (size 512):
      comm "systemd-udevd", pid 506, jiffies 4294674198 (age 3605.560s)
      hex dump (first 32 bytes):
        10 b4 9d a0 ff ff ff ff ff ff ff ff ff ff ff ff  ................
        ff ff ff ff ff ff ff ff 00 00 00 00 00 00 00 00  ................
      backtrace:
        [<ffffffff8134b901>] __kmem_cache_alloc_node+0x1c1/0x2b0
        [<ffffffff812c98b2>] __kmalloc+0x52/0x150
        [<ffffffffa08b0033>] __set_power_wells+0xc3/0x360 [xe]
        [<ffffffffa08562fc>] xe_display_init_nommio+0x4c/0x70 [xe]
        [<ffffffffa07f0d1c>] xe_device_probe+0x3c/0x5a0 [xe]
        [<ffffffffa082e48f>] xe_pci_probe+0x33f/0x5a0 [xe]
        [<ffffffff817f2187>] local_pci_probe+0x47/0xa0
        [<ffffffff817f3db3>] pci_device_probe+0xc3/0x1f0
        [<ffffffff8192f2a2>] really_probe+0x1a2/0x410
        [<ffffffff8192f598>] __driver_probe_device+0x78/0x160
        [<ffffffff8192f6ae>] driver_probe_device+0x1e/0x90
        [<ffffffff8192f92a>] __driver_attach+0xda/0x1d0
        [<ffffffff8192c95c>] bus_for_each_dev+0x7c/0xd0
        [<ffffffff8192e159>] bus_add_driver+0x119/0x220
        [<ffffffff81930d00>] driver_register+0x60/0x120
        [<ffffffffa05e50a0>] 0xffffffffa05e50a0
    
    Signed-off-by: wangxiaoming321 <xiaoming.wang at intel.com>
+ /mt/dim checkpatch 6aa961ab469df8db84bee01a55606a91a6ae5d67 drm-intel
f8c2c6b7e drm/xe/display: Fix memleak in display initialization
-:8: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#8: 
xe_device_probe -> xe_display_init_noirq -> intel_display_driver_probe_noirq

-:46: ERROR:INITIALISED_STATIC: do not initialise statics to 0
#46: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:39:
+static int intel_power_domains_init_flag = 0;

-:55: ERROR:SPACING: space required before the open parenthesis '('
#55: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:1021:
+	if(intel_power_domains_init_flag == 1)

total: 2 errors, 1 warnings, 0 checks, 26 lines checked