[PATCH] drm/xe/hwmon: Fix abi doc warnings

Nilawar, Badal badal.nilawar at intel.com
Fri Jan 26 17:11:15 UTC 2024



On 26-01-2024 21:35, Lucas De Marchi wrote:
> On Fri, Jan 26, 2024 at 09:09:43PM +0530, Badal Nilawar wrote:
>> Fix warnings in xe hwmon documentation
> 
> Please spell out the warning you are fixing. And:
> 
>      Reported-by: Stephen Rothwell <sfr at canb.auug.org.au>
>      Closes: 
> https://lore.kernel.org/all/20240125113345.291118ff@canb.auug.org.au/
> 
> and Cc who was Cc'ed in that thread. From that thread, you need a
> Fixes trailer with at least one of the commits there, but I think adding
> all should be acceptable, too.
Sure I will fix above comments and resend patch.
> 
> i915 should also be changed from a doc pov since that path is also
> reachable for xe. I think this should be done in the same patch, but
> need confirmation from i915 since they'd need to ack it.
Shouldn't i915 fix be in separate patch on drmtip?

Regards,
Badal
> 
> Lucas De Marchi
> 
>>
>> Signed-off-by: Badal Nilawar <badal.nilawar at intel.com>
>> ---
>> .../ABI/testing/sysfs-driver-intel-xe-hwmon   | 28 +++++++++----------
>> 1 file changed, 14 insertions(+), 14 deletions(-)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon 
>> b/Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon
>> index 8c321bc9dc04..48544bd970ab 100644
>> --- a/Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon
>> +++ b/Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon
>> @@ -1,6 +1,6 @@
>> -What:        /sys/devices/.../hwmon/hwmon<i>/power1_max
>> +What:        /sys/bus/pci/drivers/xe/.../hwmon/hwmon<i>/power1_max
>> Date:        September 2023
>> -KernelVersion:    6.5
>> +KernelVersion:    6.8
>> Contact:    intel-xe at lists.freedesktop.org
>> Description:    RW. Card reactive sustained  (PL1) power limit in 
>> microwatts.
>>
>> @@ -12,17 +12,17 @@ Description:    RW. Card reactive sustained  (PL1) 
>> power limit in microwatts.
>>
>>         Only supported for particular Intel xe graphics platforms.
>>
>> -What:        /sys/devices/.../hwmon/hwmon<i>/power1_rated_max
>> +What:        /sys/bus/pci/drivers/xe/.../hwmon/hwmon<i>/power1_rated_max
>> Date:        September 2023
>> -KernelVersion:    6.5
>> +KernelVersion:    6.8
>> Contact:    intel-xe at lists.freedesktop.org
>> Description:    RO. Card default power limit (default TDP setting).
>>
>>         Only supported for particular Intel xe graphics platforms.
>>
>> -What:        /sys/devices/.../hwmon/hwmon<i>/power1_crit
>> +What:        /sys/bus/pci/drivers/xe/.../hwmon/hwmon<i>/power1_crit
>> Date:        September 2023
>> -KernelVersion:    6.5
>> +KernelVersion:    6.8
>> Contact:    intel-xe at lists.freedesktop.org
>> Description:    RW. Card reactive critical (I1) power limit in 
>> microwatts.
>>
>> @@ -33,9 +33,9 @@ Description:    RW. Card reactive critical (I1) 
>> power limit in microwatts.
>>
>>         Only supported for particular Intel xe graphics platforms.
>>
>> -What:        /sys/devices/.../hwmon/hwmon<i>/curr1_crit
>> +What:        /sys/bus/pci/drivers/xe/.../hwmon/hwmon<i>/curr1_crit
>> Date:        September 2023
>> -KernelVersion:    6.5
>> +KernelVersion:    6.8
>> Contact:    intel-xe at lists.freedesktop.org
>> Description:    RW. Card reactive critical (I1) power limit in 
>> milliamperes.
>>
>> @@ -44,25 +44,25 @@ Description:    RW. Card reactive critical (I1) 
>> power limit in milliamperes.
>>         the operating frequency if the power averaged over a window
>>         exceeds this limit.
>>
>> -What:        /sys/devices/.../hwmon/hwmon<i>/in0_input
>> +What:        /sys/bus/pci/drivers/xe/.../hwmon/hwmon<i>/in0_input
>> Date:        September 2023
>> -KernelVersion:    6.5
>> +KernelVersion:    6.8
>> Contact:    intel-xe at lists.freedesktop.org
>> Description:    RO. Current Voltage in millivolt.
>>
>>         Only supported for particular Intel xe graphics platforms.
>>
>> -What:        /sys/devices/.../hwmon/hwmon<i>/energy1_input
>> +What:        /sys/bus/pci/drivers/xe/.../hwmon/hwmon<i>/energy1_input
>> Date:        September 2023
>> -KernelVersion:    6.5
>> +KernelVersion:    6.8
>> Contact:    intel-xe at lists.freedesktop.org
>> Description:    RO. Energy input of device in microjoules.
>>
>>         Only supported for particular Intel xe graphics platforms.
>>
>> -What:        /sys/devices/.../hwmon/hwmon<i>/power1_max_interval
>> +What:        
>> /sys/bus/pci/drivers/xe/.../hwmon/hwmon<i>/power1_max_interval
>> Date:        October 2023
>> -KernelVersion:    6.6
>> +KernelVersion:    6.8
>> Contact:    intel-xe at lists.freedesktop.org
>> Description:    RW. Sustained power limit interval (Tau in PL1/Tau) in
>>         milliseconds over which sustained power is averaged.
>> -- 
>> 2.25.1
>>


More information about the Intel-xe mailing list