✗ CI.checkpatch: warning for drm/xe: Expose number of dss per group and helpers

Patchwork patchwork at emeril.freedesktop.org
Wed Jan 31 01:10:03 UTC 2024


== Series Details ==

Series: drm/xe: Expose number of dss per group and helpers
URL   : https://patchwork.freedesktop.org/series/129331/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
35591fb8b4d5305b37ce31483f85ac0956eaa536
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 838d5f880307e8308c63fe8533276be2cc781efa
Author: Zhanjun Dong <zhanjun.dong at intel.com>
Date:   Tue Jan 30 10:57:44 2024 -0800

    drm/xe: Expose number of dss per group and helpers
    
    Expose helper for dss per group. This is a precursor patch to allow
    for easier iteration through MCR registers and other per-DSS uses.
    
    Signed-off-by: Zhanjun Dong <zhanjun.dong at intel.com>
+ /mt/dim checkpatch 3d244fce99b65e012c4409d8a22bb9168c41f101 drm-intel
838d5f880 drm/xe: Expose number of dss per group and helpers
-:97: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dss_' - possible side-effects?
#97: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:40:
+#define for_each_dss_steering(dss_, gt_, group_, instance_) \
+	for (dss_ = 0, xe_gt_mcr_get_dss_steering(gt_, 0, &group_, &instance_); \
+	     dss_ < XE_MAX_DSS_FUSE_BITS; \
+	     dss_++, xe_gt_mcr_get_dss_steering(gt_, dss_, &group_, &instance_)) \
+		for_each_if(_HAS_SS(gt_, group_, instance_))

-:97: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gt_' - possible side-effects?
#97: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:40:
+#define for_each_dss_steering(dss_, gt_, group_, instance_) \
+	for (dss_ = 0, xe_gt_mcr_get_dss_steering(gt_, 0, &group_, &instance_); \
+	     dss_ < XE_MAX_DSS_FUSE_BITS; \
+	     dss_++, xe_gt_mcr_get_dss_steering(gt_, dss_, &group_, &instance_)) \
+		for_each_if(_HAS_SS(gt_, group_, instance_))

-:97: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'group_' - possible side-effects?
#97: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:40:
+#define for_each_dss_steering(dss_, gt_, group_, instance_) \
+	for (dss_ = 0, xe_gt_mcr_get_dss_steering(gt_, 0, &group_, &instance_); \
+	     dss_ < XE_MAX_DSS_FUSE_BITS; \
+	     dss_++, xe_gt_mcr_get_dss_steering(gt_, dss_, &group_, &instance_)) \
+		for_each_if(_HAS_SS(gt_, group_, instance_))

-:97: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'group_' may be better as '(group_)' to avoid precedence issues
#97: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:40:
+#define for_each_dss_steering(dss_, gt_, group_, instance_) \
+	for (dss_ = 0, xe_gt_mcr_get_dss_steering(gt_, 0, &group_, &instance_); \
+	     dss_ < XE_MAX_DSS_FUSE_BITS; \
+	     dss_++, xe_gt_mcr_get_dss_steering(gt_, dss_, &group_, &instance_)) \
+		for_each_if(_HAS_SS(gt_, group_, instance_))

-:97: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'instance_' - possible side-effects?
#97: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:40:
+#define for_each_dss_steering(dss_, gt_, group_, instance_) \
+	for (dss_ = 0, xe_gt_mcr_get_dss_steering(gt_, 0, &group_, &instance_); \
+	     dss_ < XE_MAX_DSS_FUSE_BITS; \
+	     dss_++, xe_gt_mcr_get_dss_steering(gt_, dss_, &group_, &instance_)) \
+		for_each_if(_HAS_SS(gt_, group_, instance_))

-:97: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'instance_' may be better as '(instance_)' to avoid precedence issues
#97: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:40:
+#define for_each_dss_steering(dss_, gt_, group_, instance_) \
+	for (dss_ = 0, xe_gt_mcr_get_dss_steering(gt_, 0, &group_, &instance_); \
+	     dss_ < XE_MAX_DSS_FUSE_BITS; \
+	     dss_++, xe_gt_mcr_get_dss_steering(gt_, dss_, &group_, &instance_)) \
+		for_each_if(_HAS_SS(gt_, group_, instance_))

total: 0 errors, 0 warnings, 6 checks, 95 lines checked




More information about the Intel-xe mailing list