✓ CI.checkpatch: success for drm/xe: Convert job timeouts from assert to warning
Patchwork
patchwork at emeril.freedesktop.org
Wed Jan 31 03:03:45 UTC 2024
== Series Details ==
Series: drm/xe: Convert job timeouts from assert to warning
URL : https://patchwork.freedesktop.org/series/129338/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
35591fb8b4d5305b37ce31483f85ac0956eaa536
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit c19d106c7dda152545402c5cc049e7448454cdb6
Author: Matt Roper <matthew.d.roper at intel.com>
Date: Tue Jan 30 12:03:09 2024 -0800
drm/xe: Convert job timeouts from assert to warning
xe_assert() is intended to be used only for "impossible" situations that
should never be hit (and if they are hit it means there's a driver bug
somewhere); assertions are only compiled into debug builds.
Although we expect jobs submitted by the kernel to be well-behaved and
run without error, timeouts are a legitimate possibility for reasons
beyond our control (bad firmware, flaky hardware, etc.). We should use
a real WARN if we encounter these, even for non-debug builds, to ensure
the issue is being properly highlighted in bug reports and such.
Also give the WARNs more human-readable messages and move them below the
general notice-level message that gets printed for any kind of timeout
to make the errors a bit more understandable.
v2:
- Convert the VM / exec_queue_killed assertion as well. (MattB)
Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
Reviewed-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 3d244fce99b65e012c4409d8a22bb9168c41f101 drm-intel
c19d106c7 drm/xe: Convert job timeouts from assert to warning
More information about the Intel-xe
mailing list