✗ CI.checkpatch: warning for drm/xe/vm: Subclass userptr vmas (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Wed Jan 31 09:19:32 UTC 2024
== Series Details ==
Series: drm/xe/vm: Subclass userptr vmas (rev2)
URL : https://patchwork.freedesktop.org/series/129324/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
35591fb8b4d5305b37ce31483f85ac0956eaa536
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 9ca3a33aebf7368509b22ff0c65cc7a8e9192204
Author: Thomas Hellström <thomas.hellstrom at linux.intel.com>
Date: Wed Jan 31 10:16:28 2024 +0100
drm/xe/vm: Subclass userptr vmas
The construct allocating only parts of the vma structure when
the userptr part is not needed is very fragile. A developer could
add additional fields below the userptr part, and the code could
easily attempt to access the userptr part even if its not persent.
So introduce xe_userptr_vma which subclasses struct xe_vma the
proper way, and accordingly modify a couple of interfaces.
This should also help if adding userptr helpers to drm_gpuvm.
v2:
- Fix documentation of to_userptr_vma() (Matthew Brost)
- Fix allocation and freeing of vmas to clearer distinguish
between the types.
Closes: https://lore.kernel.org/intel-xe/0c4cc1a7-f409-4597-b110-81f9e45d1ffe@embeddedor.com/T/#u
Fixes: a4cc60a55fd9 ("drm/xe: Only alloc userptr part of xe_vma for userptrs")
Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Cc: Matthew Brost <matthew.brost at intel.com>
Cc: Lucas De Marchi <lucas.demarchi at intel.com>
Signed-off-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>
Reviewed-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 3d244fce99b65e012c4409d8a22bb9168c41f101 drm-intel
9ca3a33ae drm/xe/vm: Subclass userptr vmas
-:24: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id 'a4cc60a55fd9', maybe rebased or not pulled?
#24:
Fixes: a4cc60a55fd9 ("drm/xe: Only alloc userptr part of xe_vma for userptrs")
total: 0 errors, 1 warnings, 0 checks, 547 lines checked
More information about the Intel-xe
mailing list