✓ CI.checkpatch: success for xe_ggtt node refactor for safer node removal
Patchwork
patchwork at emeril.freedesktop.org
Mon Jul 1 04:39:43 UTC 2024
== Series Details ==
Series: xe_ggtt node refactor for safer node removal
URL : https://patchwork.freedesktop.org/series/135537/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
51ce9f6cd981d42d7467409d7dbc559a450abc1e
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit b600c8cea68c1db3d7d773b77545d4db1e36ed02
Author: Rodrigo Vivi <rodrigo.vivi at intel.com>
Date: Fri Jun 28 15:27:53 2024 -0400
drm/xe: Fix missing runtime outer protection for ggtt_remove_node
Defer the ggtt node removal to a thread if runtime_pm is not active.
The ggtt node removal can be called from multiple places, including
places where we cannot protect with outer callers and places we are
within other locks. So, try to grab the runtime reference if the
device is already active, otherwise defer the removal to a separate
thread from where we are sure we can wake the device up.
v2: - use xe wq instead of system wq (Matt and CI)
- Avoid GFP_KERNEL to be future proof since this removal can
be called from outside our drivers and we don't want to block
if atomic is needed. (Brost)
v3: amend forgot chunk declaring xe_device.
v4: Use a xe_ggtt_region to encapsulate the node and remova info,
wihtout the need for any memory allocation at runtime.
v5: Actually fill the delayed_removal.invalidate (Brost)
v6: - Ensure that ggtt_region is not freed before work finishes (Auld)
- Own wq to ensures that the queued works are flushed before
ggtt_fini (Brost)
v7: also free ggtt_region on early !bound return (Auld)
v8: Address the null deref (CI)
v9: Based on the new xe_ggtt_node for the proper care of the lifetime
of the object.
Cc: Matthew Auld <matthew.auld at intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
Cc: Francois Dugast <francois.dugast at intel.com>
Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
Cc: Matthew Brost <matthew.brost at intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
+ /mt/dim checkpatch 886eeb6d89b58f914ee5045fcac54b59a73d8299 drm-intel
4fa364434f8f drm/xe: Removed unused xe_ggtt_printk
41de0af5bd68 drm/xe: Introduce GGTT documentation
fd9a8bb2d952 drm/xe: Remove unnecessary drm_mm.h includes
d98117841740 drm/{i915, xe}: Avoid direct inspection of dpt_vma from outside dpt
d1a54c68ba11 drm/xe: Encapsulate drm_mm_node inside xe_ggtt_node
b564b2ec03ff drm/xe: Rename xe_ggtt_node related functions
468ca3f4f7f9 drm/xe: Limit drm_mm_node_allocated access to xe_ggtt_node
51a89f9af4ce drm/xe: Introduce xe_ggtt_largest_hole
1afde8f803b8 drm/xe: Introduce xe_ggtt_print_holes
68da23a58576 drm/xe: Rename xe_ggtt balloon functions to make the node clear
dfa0f45ef106 drm/xe: Make xe_ggtt_node struct independent
b600c8cea68c drm/xe: Fix missing runtime outer protection for ggtt_remove_node
More information about the Intel-xe
mailing list