✓ CI.checkpatch: success for xe_ggtt node refactor for safer node removal (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Mon Jul 1 04:51:27 UTC 2024
== Series Details ==
Series: xe_ggtt node refactor for safer node removal (rev2)
URL : https://patchwork.freedesktop.org/series/135537/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
51ce9f6cd981d42d7467409d7dbc559a450abc1e
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 089033f763a3d171d5bad749d8f51b15daa20ac2
Author: Rodrigo Vivi <rodrigo.vivi at intel.com>
Date: Fri Jun 28 15:27:53 2024 -0400
drm/xe: Fix missing runtime outer protection for ggtt_remove_node
Defer the ggtt node removal to a thread if runtime_pm is not active.
The ggtt node removal can be called from multiple places, including
places where we cannot protect with outer callers and places we are
within other locks. So, try to grab the runtime reference if the
device is already active, otherwise defer the removal to a separate
thread from where we are sure we can wake the device up.
v2: - use xe wq instead of system wq (Matt and CI)
- Avoid GFP_KERNEL to be future proof since this removal can
be called from outside our drivers and we don't want to block
if atomic is needed. (Brost)
v3: amend forgot chunk declaring xe_device.
v4: Use a xe_ggtt_region to encapsulate the node and remova info,
wihtout the need for any memory allocation at runtime.
v5: Actually fill the delayed_removal.invalidate (Brost)
v6: - Ensure that ggtt_region is not freed before work finishes (Auld)
- Own wq to ensures that the queued works are flushed before
ggtt_fini (Brost)
v7: also free ggtt_region on early !bound return (Auld)
v8: Address the null deref (CI)
v9: Based on the new xe_ggtt_node for the proper care of the lifetime
of the object.
Cc: Matthew Auld <matthew.auld at intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
Cc: Francois Dugast <francois.dugast at intel.com>
Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
Cc: Matthew Brost <matthew.brost at intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
+ /mt/dim checkpatch 886eeb6d89b58f914ee5045fcac54b59a73d8299 drm-intel
ff2374a8ce5c drm/xe: Removed unused xe_ggtt_printk
1190bbf94d61 drm/xe: Introduce GGTT documentation
7cff75d63fad drm/xe: Remove unnecessary drm_mm.h includes
a76482300ca5 drm/{i915, xe}: Avoid direct inspection of dpt_vma from outside dpt
18e57b53508d drm/xe: Encapsulate drm_mm_node inside xe_ggtt_node
b91912bc289c drm/xe: Rename xe_ggtt_node related functions
edab69ef9b21 drm/xe: Limit drm_mm_node_allocated access to xe_ggtt_node
c55b24bf525f drm/xe: Introduce xe_ggtt_largest_hole
719884426317 drm/xe: Introduce xe_ggtt_print_holes
ab67ed6ef94a drm/xe: Rename xe_ggtt balloon functions to make the node clear
241213d6ae60 drm/xe: Make xe_ggtt_node struct independent
089033f763a3 drm/xe: Fix missing runtime outer protection for ggtt_remove_node
More information about the Intel-xe
mailing list