✗ CI.checkpatch: warning for Add support for EU stall sampling (rev2)

[Patchwork]

== Series Details ==

Series: Add support for EU stall sampling (rev2)
URL   : https://patchwork.freedesktop.org/series/135559/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
51ce9f6cd981d42d7467409d7dbc559a450abc1e
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit dc4e0d1d5ac604330391460728a91e9e586e4061
Author: Harish Chegondi <harish.chegondi at intel.com>
Date:   Sun Jul 7 15:41:41 2024 -0700

    drm/xe/eustall: Add support for EU stall sampling
    
    A new hardware feature first introduced in PVC gives capability to
    periodically sample EU stall state and record counts for different stall
    reasons, on a per IP basis, aggregate across all EUs in a subslice and
    record the samples in a buffer in each subslice. Eventually, the aggregated
    data is written out to a buffer in the memory. This feature is also
    supported in XE2 architecture GPUs - LNL and BMG.
    
    Use an existing IOCTL DRM_IOCTL_XE_OBSERVATION as interface into the driver
    from the user space to do initial setup and obtain a file descriptor for
    the EU stall counter data stream.  Input parameter to the IOCTL is a struct
    drm_xe_observation_param in which observation_type should be set to
    DRM_XE_OBSERVATION_TYPE_EU_STALL, observation_op should be
    DRM_XE_OBSERVATION_OP_STREAM_OPEN and param should point to a chain of
    drm_xe_ext_set_property structures in which each structure has a pair of
    property and value. The EU stall sampling input properties are defined in
    drm_xe_eu_stall_property_id enum.
    
    With the file descriptor obtained from DRM_IOCTL_XE_OBSERVATION, user space
    can enable and disable EU stall sampling with
    DRM_XE_OBSERVATION_IOCTL_ENABLE and DRM_XE_OBSERVATION_IOCTL_DISABLE
    IOCTLs.  User space can also call poll() to check for availability of
    data. The data can be read with read(). EU stall data consists of header
    and data pairs. The header format is defined in struct
    drm_xe_eu_stall_data_header. If the user space doesn't read the EU stall
    data fast enough, it is possible that the EU stall data buffer can get
    filled up and if the hardware wants to write data, it simply drops data due
    to unavailable buffer space. In that case hardware sets a bit in a
    register.  The driver sets a flag in the EU stall data header flags field
    to let the user space know that the hardware has dropped data.
    
    v2: Rename xe perf layer as xe observation layer (Ashutosh)
    
    Signed-off-by: Harish Chegondi <harish.chegondi at intel.com>
    Signed-off-by: Ashutosh Dixit <ashutosh.dixit at intel.com>
+ /mt/dim checkpatch 70f1d41b827fa9d1275748e655912f991635f595 drm-intel
dc4e0d1d5ac6 drm/xe/eustall: Add support for EU stall sampling
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:54: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

-:355: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'write_ptr < read_ptr'
#355: FILE: drivers/gpu/drm/xe/xe_eustall_cntr.c:258:
+		if (unlikely((write_ptr < read_ptr) &&
+			     ((read_ptr & buf_size) == (write_ptr & buf_size)))) {

-:364: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'write_ptr != read_ptr'
#364: FILE: drivers/gpu/drm/xe/xe_eustall_cntr.c:267:
+		if ((write_ptr != read_ptr) && !min_data_present) {

-:439: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'write_ptr < read_ptr'
#439: FILE: drivers/gpu/drm/xe/xe_eustall_cntr.c:342:
+	if (unlikely((write_ptr < read_ptr) &&
+		     ((read_ptr & buf_size) == (write_ptr & buf_size)))) {

-:1094: WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#1094: FILE: drivers/gpu/drm/xe/xe_eustall_cntr.c:997:
+		drm_dbg(&xe->drm, "Invalid GT for EU stall sampling \n");

-:1303: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1303: FILE: drivers/gpu/drm/xe/xe_trace.h:385:
+	    TP_STRUCT__entry(

-:1313: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1313: FILE: drivers/gpu/drm/xe/xe_trace.h:395:
+	    TP_fast_assign(

total: 0 errors, 2 warnings, 5 checks, 1324 lines checked