✗ CI.checkpatch: warning for drm/xe/kunit: Simplify live tests code layout

Patchwork patchwork at emeril.freedesktop.org
Mon Jul 8 11:18:35 UTC 2024


== Series Details ==

Series: drm/xe/kunit: Simplify live tests code layout
URL   : https://patchwork.freedesktop.org/series/135839/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
51ce9f6cd981d42d7467409d7dbc559a450abc1e
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 0484df0e00d607dd7529398d21309c69c38adb69
Author: Michal Wajdeczko <michal.wajdeczko at intel.com>
Date:   Mon Jul 8 13:12:10 2024 +0200

    drm/xe/kunit: Simplify xe_mocs live tests code layout
    
    The test case logic is implemented by the functions compiled as
    part of the core Xe driver module and then exported to build and
    register the test suite in the live test module.
    
    But we don't need to export individual test case functions, we may
    just export the entire test suite. And we don't need to register
    this test suite in a separate file, it can be done in the main
    file of the live test module.
    
    Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
+ /mt/dim checkpatch 414cc5961337b50dd261349b4ed7aa0013044ccf drm-intel
c3ff109865a6 drm/xe/kunit: Simplify xe_bo live tests code layout
-:78: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#78: 
deleted file mode 100644

total: 0 errors, 1 warnings, 0 checks, 59 lines checked
45cab2497780 drm/xe/kunit: Simplify xe_dma_buf live tests code layout
-:64: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#64: 
deleted file mode 100644

-:116: WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#116: FILE: drivers/gpu/drm/xe/tests/xe_live_test_mod.c:9:
+extern struct kunit_suite xe_dma_buf_test_suite;

total: 0 errors, 2 warnings, 0 checks, 45 lines checked
6ae39c3dc2ee drm/xe/kunit: Simplify xe_migrate live tests code layout
-:37: WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#37: FILE: drivers/gpu/drm/xe/tests/xe_live_test_mod.c:10:
+extern struct kunit_suite xe_migrate_test_suite;

-:80: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#80: 
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 46 lines checked
0484df0e00d6 drm/xe/kunit: Simplify xe_mocs live tests code layout
-:39: WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#39: FILE: drivers/gpu/drm/xe/tests/xe_live_test_mod.c:11:
+extern struct kunit_suite xe_mocs_test_suite;

-:97: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#97: 
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 62 lines checked




More information about the Intel-xe mailing list