[PATCH] drm/xe/xe2lpg: Extend workaround 14021402888

[Matt Roper]

On Mon, Jul 08, 2024 at 12:30:19PM -0500, Lucas De Marchi wrote:
> On Wed, Jul 03, 2024 at 06:54:00AM GMT, Matt Roper wrote:
> > On Wed, Jul 03, 2024 at 02:37:54PM +0530, Bommu Krishnaiah wrote:
> > > workaround 14021402888 also applies to Xe2_LPG.
> > > Replicate the existing entry to one specific for Xe2_LPG.
> > > 
> > > Signed-off-by: Bommu Krishnaiah <krishnaiah.bommu at intel.com>
> > > Cc: Tejas Upadhyay <tejas.upadhyay at intel.com>
> > > Cc: Matt Roper <matthew.d.roper at intel.com>
> > > Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
> > 
> > Reviewed-by: Matt Roper <matthew.d.roper at intel.com>
> > 
> > > ---
> > >  drivers/gpu/drm/xe/xe_wa.c | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
> > > index c7bf0862b231..91737d7a483d 100644
> > > --- a/drivers/gpu/drm/xe/xe_wa.c
> > > +++ b/drivers/gpu/drm/xe/xe_wa.c
> > > @@ -486,6 +486,10 @@ static const struct xe_rtp_entry_sr engine_was[] = {
> > >  	  XE_RTP_RULES(GRAPHICS_VERSION(2004), FUNC(xe_rtp_match_first_render_or_compute)),
> > >  	  XE_RTP_ACTIONS(SET(TDL_TSL_CHICKEN, SLM_WMTP_RESTORE))
> > >  	},
> > > +	{ XE_RTP_NAME("14021402888"),
> > > +	  XE_RTP_RULES(GRAPHICS_VERSION(2004), ENGINE_CLASS(RENDER)),
> > > +	  XE_RTP_ACTIONS(SET(HALF_SLICE_CHICKEN7, CLEAR_OPTIMIZATION_DISABLE))
> 
> since the action is exactly the same as for GRAPHICS_VERSION(2001),
> maybe we should prefer to a) add this one here, with an OR to also apply
> in GRAPHICS_VERSION(2001) and then remove the one in the bottom of the
> array that are 2001-only. Thoughts?

We didn't have "OR" capability until a week or two ago, so the pattern
until now has been to create distinct entries for non-contiguous IP
versions.  I figure we shouldn't switch styles for just one specific
workaround, so probably best to keep distinct entries on this specific
workaround.  But as a follow-up we can decide whether we want to
mass-convert all of the shared Xe2_{LPG,HPG} workarounds to a new format
at once.  I think the options are:

 * Consolidate with OR's (might be less readable, especially if the list
   of affected platforms expands in the future?)
 * Switch to [2001..2004] ranges (would need to audit those entries if
   a new platform shows up with 2002 or 2003 in the future).
 * Keep it as is for now and only consolidate once we're a major IP
   generation farther down the road.


Matt

> 
> Lucas De Marchi
> 
> 
> 
> > > +	},
> > > 
> > >  	/* Xe2_HPG */
> > > 
> > > --
> > > 2.25.1
> > > 
> > 
> > -- 
> > Matt Roper
> > Graphics Software Engineer
> > Linux GPU Platform Enablement
> > Intel Corporation

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation