[PATCH 0/5] Have xe_vm and xe_exec_queue take references to xef
Umesh Nerlige Ramappa
umesh.nerlige.ramappa at intel.com
Mon Jul 8 20:20:58 UTC 2024
xe_file_close triggers an asynchronous queue cleanup and then frees up
the xef object. Since queue cleanup flushes all pending jobs and the KMD
stores client usage stats into the xef object after jobs are flushed, we
see a use-after-free for the xef object. Resolve this by taking a
reference to xef from it's users - xe_exec_queue and xe_vm.
Issue: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1908
@Maintainers
I need to use the below tags in the patches, but not sure which patches
to apply these on since all patches are part of the fix.
Fixes: 6109f24f87d7 ("drm/xe: Add helper to accumulate exec queue runtime")
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1908
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
Umesh Nerlige Ramappa (5):
drm/xe: Move part of xe_file cleanup to a helper
drm/xe: Add ref counting for xe_file
drm/xe: Take a reference to xe file when user creates exec_queue
drm/xe: Take a ref to xe file when user creates a VM
Revert "drm/xe: Do not access xe file when updating exec queue
run_ticks"
drivers/gpu/drm/xe/xe_device.c | 39 +++++++++++++++---------
drivers/gpu/drm/xe/xe_device.h | 12 ++++++++
drivers/gpu/drm/xe/xe_device_types.h | 3 ++
drivers/gpu/drm/xe/xe_drm_client.c | 5 +--
drivers/gpu/drm/xe/xe_exec_queue.c | 11 ++++++-
drivers/gpu/drm/xe/xe_exec_queue_types.h | 7 ++---
drivers/gpu/drm/xe/xe_vm.c | 5 ++-
7 files changed, 58 insertions(+), 24 deletions(-)
--
2.38.1
More information about the Intel-xe
mailing list