✓ CI.checkpatch: success for Have xe_vm and xe_exec_queue take references to xef (rev2)

Patchwork patchwork at emeril.freedesktop.org
Tue Jul 9 00:33:50 UTC 2024


== Series Details ==

Series: Have xe_vm and xe_exec_queue take references to xef (rev2)
URL   : https://patchwork.freedesktop.org/series/135865/
State : success

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
51ce9f6cd981d42d7467409d7dbc559a450abc1e
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit c2122d4b3a8e4ebfd3006aeef450dc7d6b67af7f
Author: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
Date:   Mon Jul 8 17:28:35 2024 -0700

    drm/xe: Fix use after free when client stats are captured
    
    xe_file_close triggers an asynchronous queue cleanup and then frees up
    the xef object. Since queue cleanup flushes all pending jobs and the KMD
    stores client usage stats into the xef object after jobs are flushed, we
    see a use-after-free for the xef object. Resolve this by taking a
    reference to xef from xe_exec_queue.
    
    While at it, revert an earlier change that contained a partial work
    around for this issue.
    
    v2:
    - Take a ref to xef even for the VM bind queue (Matt)
    - Squash patches relevant to that fix and work around (Lucas)
    
    Fixes: ce62827bc294 ("drm/xe: Do not access xe file when updating exec queue run_ticks")
    Fixes: 6109f24f87d7 ("drm/xe: Add helper to accumulate exec queue runtime")
    Closes: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1908
    Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
+ /mt/dim checkpatch 46846337d6d2d8a759af3559141909e92e174add drm-intel
366865b5458b drm/xe: Move part of xe_file cleanup to a helper
5dd886cea9db drm/xe: Add ref counting for xe_file
e1b41905a225 drm/xe: Take a ref to xe file when user creates a VM
c2122d4b3a8e drm/xe: Fix use after free when client stats are captured




More information about the Intel-xe mailing list