[PATCH 4/4] drm/xe/kunit: Simplify xe_mocs live tests code layout

Lucas De Marchi lucas.demarchi at intel.com
Thu Jul 11 21:59:00 UTC 2024


On Wed, Jul 10, 2024 at 08:03:10PM GMT, Kumar, Janga Rahul wrote:
>
>
>> -----Original Message-----
>> From: De Marchi, Lucas <lucas.demarchi at intel.com>
>> Sent: Tuesday, July 9, 2024 8:22 PM
>> To: Wajdeczko, Michal <Michal.Wajdeczko at intel.com>
>> Cc: intel-xe at lists.freedesktop.org; Kumar, Janga Rahul
>> <janga.rahul.kumar at intel.com>; Roper, Matthew D
>> <matthew.d.roper at intel.com>
>> Subject: Re: [PATCH 4/4] drm/xe/kunit: Simplify xe_mocs live tests code layout
>>
>> On Mon, Jul 08, 2024 at 01:12:10PM GMT, Michal Wajdeczko wrote:
>> >The test case logic is implemented by the functions compiled as part of
>> >the core Xe driver module and then exported to build and register the
>> >test suite in the live test module.
>> >
>> >But we don't need to export individual test case functions, we may just
>> >export the entire test suite. And we don't need to register this test
>> >suite in a separate file, it can be done in the main file of the live
>> >test module.
>> >
>> >Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
>>
>> +Matt Roper, +Janga
>>
>> We ended up implementing the mocs tests on the igt side that can test
>> additional things like keeping the values across reset. Is there any additional
>> value in keeping the kunit live version?
>Mocs Reset IGT tests are not yet added. I will be working to add those igt tests.
>Once added will remove these live tests. Till then we need these tests to be running.

fair enough, then this patch is


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

thanks
Lucas De Marchi


More information about the Intel-xe mailing list