[PATCH v3 09/11] drm/xe/exec: adding msix infra to exec queue
Ilia Levi
ilia.levi at intel.com
Wed Jul 17 07:32:21 UTC 2024
From: Dani Liberman <dliberman at habana.ai>
On MSIX platform each exec queue will allocate MSIX.
Signed-off-by: Dani Liberman <dliberman at habana.ai>
---
drivers/gpu/drm/xe/xe_exec_queue.c | 39 ++++++++++++++++++++++++
drivers/gpu/drm/xe/xe_exec_queue_types.h | 2 ++
2 files changed, 41 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c b/drivers/gpu/drm/xe/xe_exec_queue.c
index 3336a01a1006..ae4dffe96b1b 100644
--- a/drivers/gpu/drm/xe/xe_exec_queue.c
+++ b/drivers/gpu/drm/xe/xe_exec_queue.c
@@ -22,6 +22,7 @@
#include "xe_ring_ops_types.h"
#include "xe_trace.h"
#include "xe_vm.h"
+#include "xe_irq.h"
enum xe_exec_queue_sched_prop {
XE_EXEC_QUEUE_JOB_TIMEOUT = 0,
@@ -33,8 +34,40 @@ enum xe_exec_queue_sched_prop {
static int exec_queue_user_extensions(struct xe_device *xe, struct xe_exec_queue *q,
u64 extensions, int ext_number);
+static int xe_exec_queue_msix_init(struct xe_device *xe, struct xe_exec_queue *q)
+{
+ u16 msix;
+ int ret = 0;
+
+ if (!xe_device_has_msix(xe))
+ return 0;
+
+ ret = xe_irq_request_irq(xe, xe_irq_msix_hwe_handler, q->hwe, q->hwe->name, true, &msix);
+ if (ret < 0) {
+ drm_dbg(&xe->drm, "Can't allocate unique MSIX to exec queue (%d)\n", ret);
+ return ret;
+ }
+
+ q->msix_number = msix;
+
+ return 0;
+}
+
+static void xe_exec_queue_msix_fini(struct xe_exec_queue *q)
+{
+ struct xe_device *xe = gt_to_xe(q->gt);
+
+ if (!xe_device_has_msix(xe))
+ return;
+
+ if (q->msix_number)
+ xe_irq_free_irq(xe, q->msix_number);
+}
+
static void __xe_exec_queue_free(struct xe_exec_queue *q)
{
+ xe_exec_queue_msix_fini(q);
+
if (q->vm)
xe_vm_put(q->vm);
kfree(q);
@@ -81,6 +114,12 @@ static struct xe_exec_queue *__xe_exec_queue_alloc(struct xe_device *xe,
else
q->sched_props.priority = XE_EXEC_QUEUE_PRIORITY_NORMAL;
+ err = xe_exec_queue_msix_init(xe, q);
+ if (err) {
+ kfree(q);
+ return ERR_PTR(err);
+ }
+
if (vm)
q->vm = xe_vm_get(vm);
diff --git a/drivers/gpu/drm/xe/xe_exec_queue_types.h b/drivers/gpu/drm/xe/xe_exec_queue_types.h
index ded9f9396429..565ebfa4598b 100644
--- a/drivers/gpu/drm/xe/xe_exec_queue_types.h
+++ b/drivers/gpu/drm/xe/xe_exec_queue_types.h
@@ -56,6 +56,8 @@ struct xe_exec_queue {
* @logical_mask: logical mask of where job submitted to exec queue can run
*/
u32 logical_mask;
+ /** @msix_number: msix number */
+ u16 msix_number;
/** @name: name of this exec queue */
char name[MAX_FENCE_NAME_LEN];
/** @width: width (number BB submitted per exec) of this exec queue */
--
2.43.2
More information about the Intel-xe
mailing list