[PATCH v2 5/7] drm/xe/tests: Convert xe_migrate live tests

Cavitt, Jonathan jonathan.cavitt at intel.com
Wed Jul 17 20:17:49 UTC 2024


-----Original Message-----
From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Michal Wajdeczko
Sent: Wednesday, July 17, 2024 12:52 PM
To: intel-xe at lists.freedesktop.org
Cc: Wajdeczko, Michal <Michal.Wajdeczko at intel.com>
Subject: [PATCH v2 5/7] drm/xe/tests: Convert xe_migrate live tests
> 
> Convert xe_migrate live tests to parameterized style.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>

Notes from patch 4 apply here as well.
Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> ---
>  drivers/gpu/drm/xe/tests/xe_migrate.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/tests/xe_migrate.c b/drivers/gpu/drm/xe/tests/xe_migrate.c
> index 0de0e0c66623..5b4f7db004f4 100644
> --- a/drivers/gpu/drm/xe/tests/xe_migrate.c
> +++ b/drivers/gpu/drm/xe/tests/xe_migrate.c
> @@ -6,6 +6,7 @@
>  #include <kunit/test.h>
>  #include <kunit/visibility.h>
>  
> +#include "tests/xe_kunit_helpers.h"
>  #include "tests/xe_pci_test.h"
>  
>  #include "xe_pci.h"
> @@ -355,11 +356,13 @@ static int migrate_test_run_device(struct xe_device *xe)
>  
>  static void xe_migrate_sanity_kunit(struct kunit *test)
>  {
> -	xe_call_for_each_device(migrate_test_run_device);
> +	struct xe_device *xe = test->priv;
> +
> +	migrate_test_run_device(xe);
>  }
>  
>  static struct kunit_case xe_migrate_tests[] = {
> -	KUNIT_CASE(xe_migrate_sanity_kunit),
> +	KUNIT_CASE_PARAM(xe_migrate_sanity_kunit, xe_pci_live_device_gen_param),
>  	{}
>  };
>  
> @@ -367,5 +370,6 @@ VISIBLE_IF_KUNIT
>  struct kunit_suite xe_migrate_test_suite = {
>  	.name = "xe_migrate",
>  	.test_cases = xe_migrate_tests,
> +	.init = xe_kunit_helper_xe_device_live_test_init,
>  };
>  EXPORT_SYMBOL_IF_KUNIT(xe_migrate_test_suite);
> -- 
> 2.43.0
> 
> 


More information about the Intel-xe mailing list